AHBot Does Not Fill Auction House with Quest Items

[jimmybrancaccio]

This is likely related to #1427.

Current behavior:

Even if you set Quest items to a priority of 10 in the ahbot.conf file, the bot does not seem to fill the auction with any quest items.

Expected behavior:

Setting the highest priority level to a certain group of items should allow the bot to fill the auction house with those items.

Steps to reproduce:

1. Compile the latest codebase 0 any version should do (Classic, TBC or WotLK).
2. Copy over the AHBot config from src/game/AuctionHouseBot/ahbot.conf.dist.in into your etc directory as ahbot.conf.
3. Edit the AuctionHouseBot.Class.Quest value and set it to 10. Save.
4. Start up the mangosd process and you should not you get output like:

18:06:08 Quest 0 0 0 0 0 0 0

in the AHBot section of the startup process. This indicates nothing for quests is added/going to be added.

Client version:

I've tested in client version 1.12.1 but this should apply to all versions.

Commit hash:

58f93452859cd900893419a1f9276d027bdb561d

Database version:

5aa943baa455e0b96e2fd64576565bb5a175805e

Operating system:

Ubuntu 14.04

Other Notes

In working with Levi the Snek on Discord he was able to add some code to src/game/AuctionHouseBot/AuctionHouseBot.cpp:

diff --git a/src/game/AuctionHouseBot/AuctionHouseBot.cpp b/src/game/AuctionHouseBot/AuctionHouseBot.cpp
index e4372b7b9..4d0d4b416 100644
--- a/src/game/AuctionHouseBot/AuctionHouseBot.cpp
+++ b/src/game/AuctionHouseBot/AuctionHouseBot.cpp
@@ -1173,6 +1173,17 @@ bool AuctionBotSeller::Initialize()
                         continue;
                 break;
             }
+            // Levi: Just so you know, i hate MS braces, you strange people.
+            // And weird statement spacing. But hey, i'm a Snekk -- i love Python.
+            case ITEM_CLASS_QUEST:
+            case ITEM_CLASS_GEM:
+            case ITEM_CLASS_KEY:
+            case ITEM_CLASS_REAGENT:
+            {
+                // Also make sure to tell me what kind of filters should
+                // _really_ be there.
+                break;
+            }

             default:
                 continue;

This results in quest items being added to the auction house.

[ghost]

Two things:

• Don't forget that someone needs to tell us what filters are actually needs to be present, rather than having just a break from this filtering switch-case.
• This wasn't in any way specially adjusted for WotLK or Vanilla.

[cyberium]

Why? Why would you need to add quest item in AH? Want to buy Onyxia head?

[ghost]

<laughed> I believe Onyxia's head is quest-bound (bind type: quest), however Green Hills of Stranglethorn aren't -- so you can buy them.

[jimmybrancaccio]

@cyberium I think, at least in my use case, people are impatient or just don't have time to kill creatures in hopes of certain quest items dropping and would just prefer to purchase them from the auction house.

Unfortunately I only had time to test this out in Classic, but it's better illustrated in the auction house UI of say WOTLK where 'Quest' is a sub-category under Miscellaneous. To further increase the Blizzlike-ness of CMaNGOS I would think it would be a good idea to allow for such items in the auction house, even as crazy as it sounds.

[yatzi888]

I'd love it if someone could look at the AHbot not posting gems. Pretty please!

[ghost]

I did. And the patch above solves this ^_^

If you'll take a look at diff -- you'll notice ITEM_CLASS_GEM.

[jimmybrancaccio]

Just to add some clarification, I was wrong, Quests is actually it's own category in the auction house. Screenshot from WotLK:

[jimmybrancaccio]

@yatzi888 I can also confirm this works with gems:

[yatzi888]

@jimmybrancaccio That's a beautiful sight to see! I'm pretty new to this and I've needed the motivation to compile the server files myself. Guess this is a good opportunity.

[ekg98]

I believe filtering is a issue on some items too. I have a stock ahbot conf file governing it all except for quantities. I have boosted them by a order of magnitude. I have a total of 93,000 items while typing ahbot status. I was looking for cloth. Silk cloth. Only two pages of cloth added in 93,000 items and they are all higher level cloth. Mageweave Runecloth etc... No linen. Wool or Silk. I added the number for Silk cloth into the force include and I finally got a stack of silk appearing. Would this be indicative of a filtering issue with some items? I couldn't find Silk cloth in the npc_vendor.

[jimmybrancaccio]

@ekg98 Please create a new issue with full details so it can be further investigated. Thanks.

[yatzi888]

Can we get this fix applied to the TBC core please :)

[jimmybrancaccio]

Tagging @cyberium @killerwife @cala @Warlockbugs to see if we can get this merged into the cores.