search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 47 forks source link

Load map error #1819

Closed Rapth closed 5 years ago

Rapth commented 5 years ago

Current behavior: load map error Expected behavior: with no errors Steps to reproduce:

  1. extract maps with latest map extractors
  2. create a 70lv character and teleport it to any instance of Outland
  3. Server shows ERROR:Error load map file :XXX

Client version: BUILD 8606 Commit hash: latest Database version: latest Operating system: WIN10 64bit Server.log

Grz3s commented 5 years ago

nothing serious .. DB isssue....

2 creatures are spawned somewhere outside visible map ... "Coilfang: The Slave Pens"

4 creatures are spawned somewhere outside visible map ... "Hellfire Citadel: The Shattered Halls"

Its not easy to track them ..but im sure it will be fixed soon*

Rapth commented 5 years ago

Appreciate your quick reply, core runs normally without a crash,as you said ,maybe nothing serious.

evil-at-wow commented 5 years ago

That's an interesting remark, @Grz3s, about wrong spawns in the databases. It's perhaps even the reason why the error is logged by the core. But I think that's not what's actually going on here!

I recently looked into this after I found similar errors in my TBC logs for the Dire Maul map:

2018-12-21 20:31:23 ERROR:Error load map file: <path to installation>/data/maps/4293232.map
2018-12-21 20:32:00 ERROR:Error load map file: <path to installation>/data/maps/4293132.map
2018-12-21 20:33:25 ERROR:Error load map file: <path to installation>/data/maps/4293133.map
2018-12-21 20:33:31 ERROR:Error load map file: <path to installation>/data/maps/4293233.map

I noticed a pattern though, which also holds in my TBC server map files for the errors you mention: not only do the map files mentioned in errors not exist, there are no map files at all for that map! None. No map files for maps 547, 540, or 429 exist in my data/maps folder. And I think that's normal, because these instances have several levels/floors, so the geometry is more than just a simple height map. These instances seem to have a WMO.

So I think the errors here are at least misleading, and IMHO just wrong. The core should probably not even try to load any map files for these instances, but this might be difficult to know in advance. I can see the value of these errors to detect wrong spawns, but in these cases the spawns are most likely correct and there is not really problem, which makes the errors false positives at best. That's bad, but I don't know enough details of all this at the moment to suggest a better solution.

Maybe @killerwife has ideas?

Grz3s commented 5 years ago

Well maybe ... but then you should see spam of these errors ... for every creature also: I fixed similar errors by correcting spawns already... https://github.com/cmangos/wotlk-db/commit/36220e9842dd126c8d131acba34842bbeac316c2