When unlearning profession skills - skill tab is jammed full of 1-375 of that skill

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.

180 stars 47 forks source link

When unlearning profession skills - skill tab is jammed full of 1-375 of that skill #1871

Closed yatzi888 closed 5 years ago

yatzi888 commented 5 years ago

Current behavior: When unlearning a profession skill the professions tab gets jammed full of 1/375 of that skill or whatever the skill was before it was unlearnt

https://imgur.com/a/fgkArxn

relogging fixes the issue.

Expected behavior: Profession should unlearn disppearing from the skills tab

Steps to reproduce:

unlearn profession

Client version: 2.4.3

Commit hash: 4589c7b22866e86bfd29eb0ecd3c85aff45d42d1

Database version: c3ac98f8838b4318c3819485e3bae40f8e645052

Operating system: Windows Server 2012 r2

MagPurify commented 5 years ago

I was able to reproduce that.

CabrasDaPeste commented 5 years ago

Reproduced.

yatzi888 commented 5 years ago

Using this bug you can also get as many primary professions as you want. So if you learn skinning and get it 225 then unlearn, it will give you 1/150x1000 in the skills tab. THen you can pick up another profession, relog and skining will then go from 1000 seperate instances to 1 instance. Although skinning is bugged, you can then redrop it to collect another profession. Repeat this until you have all the professions. You dont need to use skinning per say, just an example.

darklordsqk commented 5 years ago

This issue happened on Classic too. Seems since dacf6d011a456cedb9ecfd5c97588e1f28749f2f the issue appeared.

Warlockbugs commented 5 years ago

Confirmed, looking into it.

Warlockbugs commented 5 years ago

The issue is complicated. Outdated spellbook code refuses to cooperate with new skills APIs on this, so i am working out acceptable ways to circumventing spellbook code in acceptable manner.

While investigating the issue, i found an exploit to add to this report: user input for unlearning skills is unverified. Anyone can unlearn any skill with basic packet editing.

Warlockbugs commented 5 years ago

2 types of possible character corruption remains to be detected and repaired:

[x] Corrupted profession state: skill line exists, but only a portion or none of the spells related to the profession are present in the spellbook
[ ] Exploited number of professions: a character has more professions than config value CONFIG_UINT32_MAX_PRIMARY_TRADE_SKILL allows for non-privileged access level accounts.

A character can have both at the time.

ulfgebhardt commented 5 years ago

@Warlockbugs will you open a ticket for that?