search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 48 forks source link

Pseudo-available quests #1979

Open Muehe opened 7 years ago

Muehe commented 7 years ago

There are 74 quests with RequiredRaces IN (0, 255), which are only available to one faction due to start and/or end NPCs being hostile to the other faction. This does not bug anything, since players can not acquire those quests, but it is a bit annoying when working with the DB. Fix.

cala commented 7 years ago

Sounds logical. I'm only asking @Tobschinski if he knows of a reason why some of those quests may be available to both factions (he has a far better knowledge of the quests availability/rewards than me due to a heavy research long ago).

Tobschinski commented 7 years ago

99% of the quests I query have AllowableRaces: -1 (with https://github.com/TrinityCore/WowPacketParser)

I'd prefer -1 over 255, but who knows if that was a thing back in the days. 0 is definitely wrong in my opinion, that should equal NO races, not all.

cala commented 7 years ago

To summarize this, quests with required races as 0 or 255 should be changed to -1 instead if I understand you.

Tobschinski commented 7 years ago

I can't tell for sure. It's one of those guesses based on a 12 years younger version of wow.

killerwife commented 7 years ago

Give me IDs of the quests, as well as packet in which I can find it. I can look in our TBC sniffs, thats the closest i have to vanilla.

Muehe commented 7 years ago 
558, 1581, 2358, 3645, 5234, 7142, 7161, 7162, 7163, 7164, 7165, 7166, 7167, 7168, 7169, 7170, 7171, 7172, 7281, 7282, 8149, 8150, 8271, 8272, 8290, 8295, 8492, 8493, 8494, 8495, 8499, 8503, 8504, 8505, 8506, 8509, 8510, 8511, 8512, 8513, 8514, 8515, 8516, 8517, 8518, 8520, 8521, 8522, 8523, 8524, 8525, 8526, 8527, 8528, 8529, 8532, 8533, 8542, 8543, 8549, 8550, 8580, 8581, 8604, 8605, 8611, 8612, 8615, 8616, 8796, 8797, 8904, 8980, 9026
Tobschinski commented 7 years ago

It is found in SMSG_QUERY_QUEST_INFO_RESPONSE these days.

You can check any quest you want, but if you want me to pick a few, do 1048 and 1049.

bdebaere commented 5 years ago

@Tobschinski Why would you prefer -1 over 255 where a flag is considered? A flag is clearly designed to check multiple things, in this case races. When everything needs to be checked, everything needs to be summed up. Not given an arbitrary number which isn't even a possible combination of the flag. I don't understand the reasoning behind wanting to step away from convention to create your own. Can you clarify?

Tobschinski commented 5 years ago

Well, first of all, this isn't my own creation. Blizzard did this. The only question is, when did they do that, from the start or at a later point. I don't possess any data from vanilla, so I can't tell you that. But the reason I prefer this too is:

-1 as data is commonly used by Blizzard and equals all or everything or maybe even not restricted. 255 however has a different meaning, it doesn't mean ALL (regardless what classes exist), it is a specific combination of classes, in this case: human, orcs, nightelves, trolls, dwarves, undeads, gnomes and tauren. There are no other classes in vanilla, yes, but it is still a restriction from the allmighty ALL. Add a new class and you would need to update this field for every quest that exists (see flag for TBC & WotLK)

AnonXS commented 2 years ago

-- CCSDB

-- ID,maxscalinglevel,AllowableRaces,logtitle
558 255 77  Jaina's Autograph
8904    255 178 Dangerous Love
8522    255 511 The Alliance Needs Runecloth Bandages!
8492    255 511 The Alliance Needs Copper Bars!
8520    255 511 The Alliance Needs Silk Bandages!
8524    255 511 The Alliance Needs Rainbow Fin Albacore!
8494    255 511 The Alliance Needs Iron Bars!
8271    255 511 Hero of the Stormpike
7162    255 511 Proving Grounds
7169    60  511 Honored Amongst the Guard
7168    60  511 Rise and Be Recognized
8505    255 511 The Alliance Needs Purple Lotus!
8796    255 511 The Alliance Needs Your Help!
8513    255 511 The Alliance Needs Medium Leather!
8499    255 511 The Alliance Needs Thorium Bars!
8549    255 511 The Horde Needs Peacebloom!
3645    255 511 Membership Card Renewal
8612    255 511 The Horde Needs More Lean Wolf Steaks!
8521    255 511 The Alliance Needs More Silk Bandages!
8518    255 511 The Alliance Needs More Linen Bandages!
7142    255 511 The Battle for Alterac
8581    255 511 The Horde Needs More Firebloom!
8506    255 511 The Alliance Needs More Purple Lotus!
8493    255 511 The Alliance Needs More Copper Bars!
8516    255 511 The Alliance Needs More Thick Leather!
8514    255 511 The Alliance Needs More Medium Leather!
8503    255 511 The Alliance Needs Stranglekelp!
9026    255 511 Tracing the Source
8509    255 511 The Alliance Needs Arthas' Tears!
1581    255 511 Elixirs for the Bladeleafs
8517    255 511 The Alliance Needs Linen Bandages!
8980    255 511 Zinge's Assessment
8272    255 511 Hero of the Frostwolf
8797    255 511 The Alliance Needs Your Help!
8523    255 511 The Alliance Needs More Runecloth Bandages!
8150    255 511 Honoring a Hero
8611    255 511 The Horde Needs Lean Wolf Steaks!
8515    255 511 The Alliance Needs Thick Leather!
8604    255 511 The Horde Needs Wool Bandages!
8504    255 511 The Alliance Needs More Stranglekelp!
8290    19  511 Vanquish the Invaders
7282    255 511 Brotherly Love
5234    255 511 Return to the Bulwark
8512    255 511 The Alliance Needs More Light Leather!
8528    255 511 The Alliance Needs Spotted Yellowtail!
8615    255 511 The Horde Needs Baked Salmon!
8295    19  511 Quell the Silverwing Usurpers
7167    60  511 The Eye of Command
7163    60  511 Rise and Be Recognized
7164    60  511 Honored Amongst the Clan
7165    60  511 Earned Reverence
7166    60  511 Legendary Heroes
8527    255 511 The Alliance Needs More Roast Raptor!
8511    255 511 The Alliance Needs Light Leather!
7161    255 511 Proving Grounds
8542    255 511 The Horde Needs Tin Bars!
8525    255 511 The Alliance Needs More Rainbow Fin Albacore!
8495    255 511 The Alliance Needs More Iron Bars!
7172    60  511 The Eye of Command
8580    255 511 The Horde Needs Firebloom!
8149    255 511 Honoring a Hero
7281    255 511 Brotherly Love
8526    255 511 The Alliance Needs Roast Raptor!
8532    255 511 The Horde Needs Copper Bars!

-- tbc-bruteforce

ID,maxscalinglevel,AllowableRaces,logtitle
8904    255 690 Dangerous Love
558 255 1101    Jaina's Autograph
9026    255 1791    Tracing the Source
8980    255 1791    Zinge's Assessment
8797    255 1791    The Alliance Needs Your Help!
8796    255 1791    The Alliance Needs Your Help!
8615    255 1791    The Horde Needs Baked Salmon!
8612    255 1791    The Horde Needs More Lean Wolf Steaks!
8611    255 1791    The Horde Needs Lean Wolf Steaks!
8605    255 1791    The Horde Needs More Wool Bandages!
8604    255 1791    The Horde Needs Wool Bandages!
8581    255 1791    The Horde Needs More Firebloom!
8580    255 1791    The Horde Needs Firebloom!
8550    255 1791    The Horde Needs More Peacebloom!
8549    255 1791    The Horde Needs Peacebloom!
8543    255 1791    The Horde Needs More Tin Bars!
8542    255 1791    The Horde Needs Tin Bars!
8533    255 1791    The Horde Needs More Copper Bars!
8532    255 1791    The Horde Needs Copper Bars!
8529    255 1791    The Alliance Needs More Spotted Yellowtail!
8528    255 1791    The Alliance Needs Spotted Yellowtail!
8527    255 1791    The Alliance Needs More Roast Raptor!
8526    255 1791    The Alliance Needs Roast Raptor!
8525    255 1791    The Alliance Needs More Rainbow Fin Albacore!
8524    255 1791    The Alliance Needs Rainbow Fin Albacore!
8523    255 1791    The Alliance Needs More Runecloth Bandages!
8522    255 1791    The Alliance Needs Runecloth Bandages!
8521    255 1791    The Alliance Needs More Silk Bandages!
8520    255 1791    The Alliance Needs Silk Bandages!
8518    255 1791    The Alliance Needs More Linen Bandages!
8517    255 1791    The Alliance Needs Linen Bandages!
8516    255 1791    The Alliance Needs More Thick Leather!
8515    255 1791    The Alliance Needs Thick Leather!
8514    255 1791    The Alliance Needs More Medium Leather!
8513    255 1791    The Alliance Needs Medium Leather!
8512    255 1791    The Alliance Needs More Light Leather!
8511    255 1791    The Alliance Needs Light Leather!
8510    255 1791    The Alliance Needs More Arthas' Tears!
8509    255 1791    The Alliance Needs Arthas' Tears!
8506    255 1791    The Alliance Needs More Purple Lotus!
8505    255 1791    The Alliance Needs Purple Lotus!
8504    255 1791    The Alliance Needs More Stranglekelp!
8503    255 1791    The Alliance Needs Stranglekelp!
8499    255 1791    The Alliance Needs Thorium Bars!
8495    255 1791    The Alliance Needs More Iron Bars!
8494    255 1791    The Alliance Needs Iron Bars!
8493    255 1791    The Alliance Needs More Copper Bars!
8492    255 1791    The Alliance Needs Copper Bars!
8295    19  1791    Quell the Silverwing Usurpers
8290    19  1791    Vanquish the Invaders
8272    255 1791    Hero of the Frostwolf
8271    255 1791    Hero of the Stormpike
8150    255 1791    Honoring a Hero
8149    255 1791    Honoring a Hero
7282    255 1791    Brotherly Love
7281    255 1791    Brotherly Love
7172    255 1791    The Eye of Command
7171    255 1791    Legendary Heroes
7170    255 1791    Earned Reverence
7169    255 1791    Honored Amongst the Guard
7168    255 1791    Rise and Be Recognized
7167    255 1791    The Eye of Command
7166    255 1791    Legendary Heroes
7165    255 1791    Earned Reverence
7164    255 1791    Honored Amongst the Clan
7163    255 1791    Rise and Be Recognized
7162    255 1791    Proving Grounds
7161    255 1791    Proving Grounds
7142    255 1791    The Battle for Alterac
5234    255 1791    Return to the Bulwark
3645    255 1791    Membership Card Renewal
1581    255 1791    Elixirs for the Bladeleafs