Patches that could be worked on

cmangos-bot commented 11 years ago

Created by @ghost on 2012-08-26 10:55:15

Hi guys,

this is a list of patches that could be contributed in a neat way: They should be relatively easy, touch not too many parts of the code and relay into relatively clear parts of the code.

Maybe someone want's to pic up some as challenge and to get some feeling into mangos code!

If you need help related to any of these suggestions, just drop by in IRC on irc.rizon.net channel #cmangos

There is no need to address issues here in any order - pick any you consider challenging!

1) Conditions system: Remove old system Done in [12184]

2) Conditions system: Expand for non-player conditions Done In [12304] to [12308]

3) CreatureAI - Move CombatMovement from SD2 or EventAi to CreatureAi Done in [12314]

5) Some Bug Reports and fix drafts Well this requires testing before vs after, maybe some problem analysis and some thoughts about.

If you want to test a bug you must test:

What does not (in which way) work before the patch. This will give you some feeling for the problems
What changes the patch (and why!) - Actually the why part is the important part, because this is the understanding of the problem and a solution
What might destroy the patch -- Well this is the most difficult, depending on the patch - which possible negative sideeffects might be there?

7) Not Moving Mobs Attack behaviour Normal NPCs that are routet should attack enemies in range, and not the tank if the tank is too far away. This is a rather generic behaviour, but there are a few not too easy parts Examples: a normal melee mob will attack enemies in range if rooted, a caster mob will continue fireballing his enemy, as will a hunter (if no enemy is in range)

Main Difficulty: Which mobs should under which circumstances prefer melee targets???

Touches: Unit::SelectHostileTarget and Unit::IsSecondChoiceTarget Actually most of the required implementional interface for this is already in place, so basicly all cools down for a neat wrapper to define this behaviour. Maybe CreatureAI is a good place, maybe Creature is good enough Here are some old code snippets related to SelectHostileTarget and prefering Melee - much of this patch is already included in master, but maybe some parts give an inspiration :) http://paste2.org/p/2078785

8) Expanding item_convert functionality Main commit: d375d7d0e47969d093c4f3f65eea741cdc73290 In the moment item_convert is only used for BOA items, and i think it would be nice to use this for normal ally/horde items as well With a possible main goal could be the loot system, to allow writing loot-tables that contain as example only the alliance item, but horde players can loot this item as well, but get the converted (horde) item displayed and looted. This should make things easier for DB-providers, prevent some unwanted effects with mixed groups and items with conditions (the TEAM condition would be required only in rare cases). And also simplify other places as well.

9) Converting "custom" table loading to generic SQLStorage Systems As with commit [12190] is must be possible to load most tables with the generic SQLStorages:

SQLStorage for a table that is pretty much filled
SQLHashStorage for a table that is not too small, and contains relatively view entries (SELECT MAX(key), COUNT(key) FROM table; -- "key" is normally entry, guid, id or such
SQLMultiStorage for a table that contains no unique-field key (like gossip tables maybe)

Advantages:

Cleaning and optimizing code in mangos
Getting along different data structures and tables, which is always good

Example commit: https://github.com/cmangos/mangos-wotlk/commit/1cd91c699bae4523b436b3a2ae4203027771014b

10) Save and use a Pool-respawn time In the moment the pool system does not safe any respawn-time to the database. As result of this, all pools are fully spawned on server-start.

It would be nice to store respawn-times in the (characters) db, and reuse them on server-start to get better results.

11) Add EncounterState functionality to tbc/classic See replies in http://www.scriptdev2.com/project.php?issueid=1607

12) Update documentation to markdown (or another well readable supported format) _12a) Update doc/EventAI.txt file_ _12b) Update doc/script_commands.txt file_ _12c) Update other remaining text-files, maybe incorporate into our wiki_

cmangos-bot commented 11 years ago

Comment by @rsa on 2012-08-26 04:27:40

:(

cmangos-bot commented 11 years ago

Comment by @Schmoozerd on 2012-08-26 04:31:46

what is wrong? - i didn't have yet time to cleanup the style, this is from my old forum post

actually i thought this was a good way to get people to try to do things - some suggestions and tasks :)

cmangos-bot commented 11 years ago

Comment by @rsa on 2012-08-26 04:44:21

nothing wrong with that, but I'm see just that you have no idea the source of problems with combat movement and attack behavior... but because you'll find a solution at least as I am (I spent almost a year).

cmangos-bot commented 11 years ago

Comment by @Schmoozerd on 2012-08-26 05:11:07

Actually my intention of part 7 is some very high-level function. That basicly boils down to some sort of: bool ShouldMobPreferMeleeTargets();

Such bool-function provided it should be possible to use this also with momentarily (though oven insufficient) code to get a much better working effect for mobs. And this high-level function will most likely stll be usefull when the underlying movement systems are improved drasticly

Phatcat commented 7 years ago

Number 5 is not something that belongs in an issue ticket but rather on the wiki or the readme..

AnonXS commented 6 years ago

(7) Outsourced to https://github.com/cmangos/issues/issues/1378

jimmybrancaccio commented 5 years ago

I will be splitting this out into their own individual issues shortly.

cmangos / issues

Patches that could be worked on #2