🐛 [Bug Report] Relations.cpp function `CanAttack` problem

Problem

When a player goes into a netrual city to reset his talent, the NPC will cast "Untalent Visual Effect" to player, so it will trigger melee attack. (mangos-tbc version)

Repro steps:

Create an undead character.
Level up him to 10+.
Go to Orgrimmar class trainner
Request reset talent.
The NPC will attack the character. Due to cast "Untalent Visual Effect" to player causes auto melee attack.

Investigation

https://github.com/cmangos/mangos-tbc/blob/master/src/game/Entities/Relations.cpp#L449

In line 449, it prevents attack only when the player's reputation >= friendly. But in this case, Orgrimmar is netrual to a fresh Undead.

Besides, cast "Untalent Visual Effect" will trigger NPC auto melee attacks.

Suggestions

Not sure how to fix it in a right way. A workaround is limit the netrual NPCs only can attack player when the NPCs are attacked by players.

if (!thisPlayerControlled && unitPlayerControlled)
{
    if (!IsEnemy(unit) && !IsAttackedBy((Unit*)unit))
        return false;
}

But not sure if there may be some case that the natrual NPCs will attack players actively, then it will be broken down by this workaround.

In another hand. Not sure it is a relation problem or a spell problem. Is there any flags could be attached into spell that don't trigger auto melee attack?

cmangos / issues