cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 47 forks source link

🐛 [Bug Report] Server-side pathing on players #2127

Open BlessedCammi opened 4 years ago

BlessedCammi commented 4 years ago

🐛 Bugreport

This has been an issue for a longtime, since I started developing on cmangos. I was hoping the recent @Warlockbugs work on the fear pathing would have resolved it. Unfortunately it is still an issue.

Footage of the bug occuring - https://youtu.be/DiaaHuNsc78?t=256

Basically whats happening is the player being feared locks in place and then once the fear runs off, the player than completes the fear path they should have been following but in rapid pace.

Expected behavior

Player character should consistantly follow the fear path chosen, not freeze and complete it once the fear duration is over.

Client Version: 2.4.3

CMaNGOS Repo & Commit Hash: cmangos/mangos-tbc@3e650fd

Database Repo & Commit Hash:

Operating System: Win

Steps to reproduce

Unsure how to reproduce it. It's 100% not npc fear pathing, it's player pathing and it happens very often.

Crashlog

BlessedCammi commented 4 years ago

Oh to add, I can't seem to replicate this problem with just two characters fearing eachother. I have a feeling it's occurance is based on the number of players in a given space as it seems very common in battlegrounds.

Warlockbugs commented 4 years ago

It can't be replicated, because player in the video appears to have network lag spike or got a client screen freeze.

BlessedCammi commented 4 years ago

This happens all the time though and it definitly isnt a client freeze and I pretty confident it isn't network lag. It must be related to update movement packets not being sent for some reason or being sent incorrectly if multiple players are in visability. The core does seem to have packet distribution issues, like the running on the spot bug from the past or crashes effecting other clients. This one is just tricky to pinpoint but I can assure you it happens a lot. I will dedicate some time into trying to find a way to replicate it so you can see it for yourself.

BlessedCammi commented 4 years ago

It also isnt just fear pathing, it's any pathing handled by the server on a player. You can see the same result for confused pathing. The player will run on the spot and then once the debuff falls off they will ping over to the final waypoint. It's like the updates packets stop being recieved from other clients and then when the player moves again (not serverside movement) it gets updated properly.

BlessedCammi commented 4 years ago

Also I just want to post the point that this isnt a recent issue. This is video footage of it happening almost a year ago and at this point I was scaling raids not scripting much at all. https://youtu.be/VF7X7120W3w?t=447 Watch the far player getting feared in the background a second into from the timestamp, it happens straight away so be careful not to miss it.

BlessedCammi commented 4 years ago

Also notice the feral druid at the very far back getting feared here - https://youtu.be/VF7X7120W3w?t=133