cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

🚀 [Feature Request] Seal / Totem Twisting TBC/Classic #2447

Open al3xc1985 opened 3 years ago

al3xc1985 commented 3 years ago

🚀 Feature

Everyone know what seal twisting is all about. I am just not able to do it on cmangos. Do we have this feature in there? if not, I am letting this here just for a humble request for this feature!

Visualisation

Benefits & Purpose

insunaa commented 3 years ago

Pretty sure Seal Twisting is an artifact of spell batching. As far as I know CMaNGOS does not use batching and instead handles events as they come in. 1.x.x and 2.x.x did actually utilize spell batching, so having this would be accurate to the reference, but it would 1) Require massive re-working of the networking code 2) Make the experience less enjoyable for users, as while seal twisting or damage-vanishing are fun mechanics, spell batching is almost universally disliked for its other negative effects.

The way I see it this could be handled in 3 ways: 1) Actually implement hard batching in network code (Lots of work, but accurate to the source) 2) Implement fake batching for seals and vanish (A bit of work and not really accurate to the source) 3) Leave it as it is (No work and not accurate to the source, but more pleasant in most other aspects)

That's it for my unqualified opinion

al3xc1985 commented 2 years ago

I also add on the list totem twisting

al3xc1985 commented 1 year ago

https://www.youtube.com/watch?v=PsCnU5RgIbQ

I let this video for reference as it is very descpritive of how seal twisting works

AnonXS commented 1 year ago

https://github.com/search?q=repo%3ALooking4Group%2FL4G_Core+SPELL_ATTR_CU_FAKE_DELAY&type=code

https://github.com/Looking4Group/L4G_Core/commit/fb5cb7fb8934c2d8e55014c97609da5055078deb

though this is no way of implementing this in cmangos and it also does not solve the aura removal issue. when new seal is cast. (fine way would prob do it via spellscript.

al3xc1985 commented 1 year ago

U are such a geniues!