search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

🐛 [Bug Report] Leash timer reset on retail without damage taken #2807

Open Nytanath opened 2 years ago

Nytanath commented 2 years ago

Bug Details

On both Classic and TBC PTRs, creatures can reset their leash timers even without taking damage. I've taken a mob from the cave near Orgrimmar to Razor Hill without doing a single point of damage to it:

https://mega.nz/file/W7JnDKoR#MUc4Up71FlqfVV2x-4LZhu3zPnjaooeulytJGc5tTqs

I believe the timer resets when a mob deals damage, but am not sure enough to make a PR about it.

Steps to Reproduce

  1. Aggro a mob.
  2. Move away from its spawn point, allowing it to attack you all the while.
  3. Notice that on retail the mob will keep attacking you, while on CMaNGOS it will leash back as soon as it can.

Expected behavior

No response

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

c07a5962627101606da7b323043f6a5d1c411bcf

Database SHA1 Commit Hash

438d5b958e059332230bd7347975a63893371d79

Operating System

Windows 10, x64

Client Version

1.1.12 (Classic)

killerwife commented 2 years ago

Well, the fun and interactive problem is that leashing on classic is not the same leashing there was on classic when it launched in 2019, and you still cannot kite things across zones (I think). And whats more, do the same thing with a ranged mob in different locations and you get different results. Problem is if mob dealing damage to you reset leash, they would infinitely chase if you were slow and permanently just running and mob was faster than you.

Nytanath commented 2 years ago

Got it, thanks! Yeah it could lead to never leashing in that case. I'll do some more testing with other creatures, but if it's really different in current classic/tbc then there's not much to do.

killerwife commented 2 years ago

I played around with it a lot myself and the current combined design of location + timer seems to be at least not violently frustrating and enables to do most stuff you should be able to do. That being said, I am never 100% about it.

Nytanath commented 2 years ago

Doesn't seem to apply on ranged mobs. I've found this article that goes into a little more detail (under "Extending the leash"), but not enough to draw conclusions. I'll investigate some more, but yeah it's a less relevant thing than I first thought, and the current implementation works good enough.