search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 47 forks source link

WOTLK quest 9918 Not on my watch rep reward is not correct with FIX🐛 [Bug Report] #2818

Open Eriumango opened 2 years ago

Eriumango commented 2 years ago

Bug Details

this quest is supposed to grant 1000 rep with the kurenai and only grants 500. this is important as 1000 gets you to neutral with that faction and you can pick up the follow up quests.

Steps to Reproduce

  1. create a test char set it to level 65 and teleport to telaar.
  2. get the quest do my eyes decieve me from huntress bintrook in telaar quest 9917
  3. do the follow up not on my watch quest 9918
  4. hand it in, you should get 1000 rep and move to neutral with the kurenai

Expected behavior

get 1000 rep, not 500

Suggested Workaround

Update the database wotlkmangos with the following Update quest_template SET RewRepValueId1 = 8 WHERE entry = 9918; tested in my own server and this works fine.

Crash Log

No response

Core SHA1 Commit Hash

56f5cbf46046f6cece2c1f3ca2a07f540561cb08

Database SHA1 Commit Hash

8b341a7d658ff4b362ddb142fde099039833793f

Operating System

ubuntu 20.04

Client Version

3.3.5a (Wrath of the Lich King)

Grz3s commented 2 years ago

and where that info comming from? https://www.wowhead.com/quest=9918/not-on-my-watch -- says 500

Eriumango commented 2 years ago

Just did it in tbc classic and I got 1000 rep, if you don’t get it then you won’t be neutral and can’t do the follow up with killing a couple hundred ogres to get to neutral

Get Outlook for iOShttps://aka.ms/o0ukef

From: Grz3s @.> Sent: Sunday, March 27, 2022 11:49:32 PM To: cmangos/issues @.> Cc: Eriumango @.>; Author @.> Subject: Re: [cmangos/issues] WOTLK quest 9918 Not on my watch rep reward is not correct with FIX🐛 [Bug Report] (Issue #2818)

and where that info comming from? https://www.wowhead.com/quest=9918/not-on-my-watch -- says 500

— Reply to this email directly, view it on GitHubhttps://github.com/cmangos/issues/issues/2818#issuecomment-1080035720, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXX22VMKOA5HBRURMI5HQLLVCDXYZANCNFSM5RZMLIZQ. You are receiving this because you authored the thread.Message ID: @.***>

Grz3s commented 2 years ago

This actualy may be correct... TBC Classic vids show 1000... Sniffs from pre. 2010 needs to be checked again then.... @AnonXS maybe?

Nytanath commented 2 years ago

I can confirm that Mag'har and Kurenai reputation from quests should be double compared to what Wowhead says in TBC too. Currently CMaNGOS has it for WotLK only. Check this old comment on the Obsidian Warbeads (item for a repeatable quest), while the quest itself says 250. I don't know if it was changed in a patch or was always like this, but at least it's confirmed for late TBC. It seems like we can use Wowwiki 2010 values (or maybe even retail - it doesn't seem like those reputation values were changed).

Ideally this would be done via the reputation_reward_rate table, but there's an issue: quests like the one I mentioned above (10476) had their reputation in quest_template changed to the "correct" value (500 instead of 250), so doubling that would be wrong. I don't know which quests were fixed like this and which weren't, so to make sure all reputation values for both factions need to be checked. I will do it when I have some more free time.

Eriumango commented 2 years ago

Also check the tbc database and it’s 1000 rep in there too

Get Outlook for iOShttps://aka.ms/o0ukef

From: I Byrne @.> Sent: Sunday, March 27, 2022 11:52:55 PM To: cmangos/issues @.>; cmangos/issues @.> Cc: Author @.> Subject: Re: [cmangos/issues] WOTLK quest 9918 Not on my watch rep reward is not correct with FIX🐛 [Bug Report] (Issue #2818)

Just did it in tbc classic and I got 1000 rep, if you don’t get it then you won’t be neutral and can’t do the follow up with killing a couple hundred ogres to get to neutral

Get Outlook for iOShttps://aka.ms/o0ukef

From: Grz3s @.> Sent: Sunday, March 27, 2022 11:49:32 PM To: cmangos/issues @.> Cc: Eriumango @.>; Author @.> Subject: Re: [cmangos/issues] WOTLK quest 9918 Not on my watch rep reward is not correct with FIX🐛 [Bug Report] (Issue #2818)

and where that info comming from? https://www.wowhead.com/quest=9918/not-on-my-watch -- says 500

— Reply to this email directly, view it on GitHubhttps://github.com/cmangos/issues/issues/2818#issuecomment-1080035720, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AXX22VMKOA5HBRURMI5HQLLVCDXYZANCNFSM5RZMLIZQ. You are receiving this because you authored the thread.Message ID: @.***>