[TBC] Debuff limit

[overy]

Max debuff limit for TBC is 40. I dont understand how it is work in core, but in SpellAuraHolder::_AddSpellAuraHolder are

else // empty negative slot { for (uint8 i = MAX_POSITIVE_AURAS; i < MAX_AURAS; i++) { if (m_target->GetUInt32Value((uint16)(UNIT_FIELD_AURA + i)) == 0) { slot = i; break; } } }

So we are can have 16 debuffs? (MAX_POSITIVE_AURAS is 40 and MAX_AURAS is 56) but correct is 40 debuffs.

[cyberium]

Ok for debuff but whats the max buff?

[overy]

16? because max on TBC is 56 auras so 56-40 = 16.

[cyberium]

I dont find the reference of max aura 56 anywhere (except in the core code ofc) So actualy iam sure from wowwiki and other patch log source that 40 debuff is right, but not for max buff. Any reference?

[Rockette]

I think this article can help you : http://wow.joystiq.com/2008/12/03/debuff-limit-removed/

[Ve1vet]

3 Dec 2008 - this is WOTLK, not TBC.

[Dramacydal]

@cyberium there are 56 updatefields, so the source is client

[killerwife]

The only mention I found of this thingy is this http://wowwiki.wikia.com/wiki/API_UnitAura http://wowwiki.wikia.com/wiki/API_UnitDebuff http://wowwiki.wikia.com/wiki/API_UnitBuff Debuff had maximum index of 40, but the maximum index for buff was unlimited. Can be tested by writing own addon and using a higher index for HELPFUL than 16 maybe?

[VladimirMangos]

We can't send to client more 16 debuffs data in TBC. I notsure at 100% how this work in TBC days at official servers. Maybe possible have more debuffs but only first 16 show to client. But this must create problems with diff debuff affected values that show client by self...

[killerwife]

So then the code snippet is correct, and working properly, or whats the issue here?

[VladimirMangos]

It's correct in data sending to client (visible from client debufffs [CD]). I not sure abour server side (really applied to unit debuffs [RD]). Currently CD == RD This is correct if no confirmations in existance hidden server-side debufs in TBC time. For decalare it as incorrect need confirm cases when more 16 debufs applied but its not show all client (last expected).

[cyberium]

Not an issue

[killerwife]

It is an issue ^^ Should have solution in cmangos within next 1-2 months. Keeping it open till then.

[cyberium]

Ok so it will be closed in 2 month 👍

[dagochen]

half a year later .... ;) @killerwife @cyberium

[killerwife]

Believe it or not, most of it is already out. I exported all the packet implementation. Only the smallest last part is missing. Expect it on next export spree next month. (you know I do these periodically)

[jimmybrancaccio]

@killerwife Just touching base on this one since it's been a while 😁

[killerwife]

Done a few months ago.