cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

🐛 [Bug Report] Naxx 25 - Thaddius encounter bugged #3035

Closed danjohnso closed 1 year ago

danjohnso commented 2 years ago

Bug Details

Couple issues with this encounter. 1) Stalagg and Fuegen never throw the tanks to swap them 2) Thaddius himself never spawns when Stalagg and Fuegen die

Steps to Reproduce

  1. Engage stalagg and fuegen
  2. Kill simultaneously
  3. Jump down to Thaddius platform, next event never starts

Expected behavior

Thaddius should activate and attack

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

ad3ecbe34282a33fc5b06550cdd403e89062fd5f

Database SHA1 Commit Hash

5ef13c94785bda2150f2be683d631ae4f301579b

Operating System

Ubuntu 20.04 LTS

Client Version

3.3.5a (Wrath of the Lich King)

insunaa commented 2 years ago

@danjohnso Try using this PR https://github.com/cmangos/mangos-wotlk/pull/366 ( https://github.com/cmangos/mangos-wotlk/pull/366.patch )

This should work (I can't test with multiple people. If it works for you I'll convert the Bosses to Spell Lists / CombatAI

Edit: You're going to need to add the following in the DB before this can work

INSERT INTO spell_scripts(Id, ScriptName) VALUES (54517, "spell_magnetic_pull");
danjohnso commented 2 years ago

So activation works now, so does the tank toss. The toss should do a threat swap or reset (don't remember, have to go look for a video), but right now they just leave their platform and go to the other one where their tank went.

Now that I can see Thaddius, the polarity charges are not working either. Had a negative and positive stand on each other, no damage was taken by either party.

killerwife commented 2 years ago

Likely the script for polarity change needs to be ported from vanilla. Cala added it theresome time ago.

insunaa commented 2 years ago

So activation works now, so does the tank toss. The toss should do a threat swap or reset (don't remember, have to go look for a video), but right now they just leave their platform and go to the other one where their tank went.

Now that I can see Thaddius, the polarity charges are not working either. Had a negative and positive stand on each other, no damage was taken by either party.

That is strange, I explicitly implemented an aggro swap. I'll rework it.

I'll take a look at the polarity change spellscript. I'm pretty sure it works on TBC too

insunaa commented 2 years ago

@danjohnso I updated the script again. I'm now manually exchanging threat values for the tanks and I've added Cala's spellscripts for the electric charges

(You'll have to execute:

INSERT INTO spell_scripts(Id, ScriptName) VALUES
(28059,'spell_thaddius_charge_buff'),
(28084,'spell_thaddius_charge_buff'),
(28062,'spell_thaddius_charge_damage'),
(28085,'spell_thaddius_charge_damage');
danjohnso commented 2 years ago

Aggro looks good, might test further later today but initial look is good.

The polarity damage is still not working, nothing in combat log from it.

Guess I forgot to copy in some of test results from yesterday, but there should also be a chain lightning damage that goes out if Stalagg or Fuegen get too far from their tether. Nothing happens right now if they get too far

insunaa commented 2 years ago

@danjohnso You added the MySQL stuff I put in the comment? If so then the spell IDs may have changed from 2.4.x (some have been re-used so I can't be sure)

Comparing our script to TrinityCore: The Spell IDs are the same

danjohnso commented 2 years ago

Yeah I ran that script

insunaa commented 2 years ago

OK I figured out the problem. The Damage is dealt by the buff, not by the Aura. So you need 3 players at least to get the damage. I'll see if I can fix this.

insunaa commented 2 years ago

@danjohnso Should be fixed now. Try with the latest code and add

INSERT INTO spell_scripts(Id, ScriptName) VALUES
(28089,'spell_thaddius_polarity_shift');
insunaa commented 2 years ago

OK, getting the Tesla Coils to work with breaking the link is a huge chunk of work that I currently do not have the energy for. I'll look into when I feel better.

What works:

What doesn't work:

AnonXS commented 1 year ago

https://github.com/cmangos/mangos-wotlk/commit/fe4b752e14083de6a487c90929ff29f4371cb4a2