🐛 [Bug Report] Berserking - Troll racial

[ghost]

Bug Details

Attack and cast speeds are incorrectly modified by the ability. 1) Cast speed – works like other haste mods: ÷ 1.1 to 1.3 2) Attack speed – I'm not sure exactly what is wrong here. I'm getting a different bonus on each use at the same health %, sometimes a lot more than expected.

Expected behavior

1) Reduces cast time by 10-30% × .9 to .7 The tooltip is misleading, which is why there are many reports of 43% max increase from classic players. 1.43⁻¹ = 0.7 2) Increases the number of swings: ÷ 1.1 to 1.3

https://pastebin.com/NNZYPfvz

https://tbc.wowhead.com/spell=20554/berserking (mana) https://tbc.wowhead.com/spell=26296/berserking (rage) https://tbc.wowhead.com/spell=26297/berserking (energy)

Core SHA1 Commit Hash

9d3602ca41bc9e51dee0b0e34b23faf012dac0d1

Database SHA1 Commit Hash

72b35099e6059cadf5becdb5eeca4013d99a6c15

Operating System

Windows 10

Client Version

2.4.3 (The Burning Crusade)

[killerwife]

There are two things to unpack here. We do not know the exact formula for the range. There is an old formula we used for ages and its used for up to 40% health. Full effect below > 40, minimal effect on full health.

The other discussion here is the casting speed. What I did was this:

Shaman troll, my lightning bolt is 2 seconds cast time.

I use berserking on full health, it goes down to 1.82 seconds, which is roughly 10% increase.

I used berserking on 1% health, it goes down to 1.54, which is roughly 30% increase.

Failing to see the issue here. Please provide more information

[ghost]

Looks like I was wrong about the cast speed: Patch 2.2.0 — Troll Berserk: The spell haste on this ability was incorrectly too high and has been corrected. Sixx (2021-3-25): "Troll Berserking haste is nerfed to maxing out at 30%, instead of like classic at 43%."

pre-2.2 Lightning Bolt, ≤40% HP: 2 × 0.7 = 1.4 sec

The health range breakpoint is still 40% afaik. BCC spreadsheets use that value and it's mentioned in several discord/reddit comments. I don't know the exact formula.

Take a look at the melee attack speed gain. It's random and inaccurate.

[killerwife]

Melee attack speed gain isnt random, its actually set to exactly what cast speed is set to. I.e. 10-30% Same goes for ranged attack speed.

[ghost]

Attack speed: 2.0 sec , Warrior --- 100% HP 1.49 1.56 1.74 1.68 1.54 1.65 1.78 1.75 1.61 1.56 1.69 1.57 --- 50% HP 1.47 1.45 1.42 1.48 1.46 1.43 1.53 1.37 1.47 1.56 1.53 1.42 --- 1% HP 1.39 1.47 1.40 1.54 1.36 1.33 1.54 1.43 1.33 1.40 1.43 1.49 ------