search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 48 forks source link

🐛 [Bug Report] Cheat Death aura #3123

Open Heisen59 opened 2 years ago

Heisen59 commented 2 years ago

Bug Details

Cheat Death aura does not reduce damage.

Steps to Reproduce

  1. Create a rogue
  2. Learn Cheat Death talents
  3. Get hit until Cheat Death aura is cast
  4. Damages are not reduced while aura is active

Expected behavior

Damages should be reduced by up to 90%

image

I don't know how resilience is affecting this.

Suggested Workaround

Unit.cpp lines 9683 and 8783 (search for case 45182) if (mod < float(mDummyAura->GetModifier()->m_amount))

it should be

if (mod > float(mDummyAura->GetModifier()->m_amount)) since mod and m_amount are both negative values.

image

Crash Log

No crash log.

Core SHA1 Commit Hash

3a81d86d7eb0428b66c10d67a764eca05a3dca13

Database SHA1 Commit Hash

667167d1ceb50e0864e308029cc48c1e72bf20d3

Operating System

Windows

Client Version

3.3.5a (Wrath of the Lich King)

killerwife commented 2 years ago

When testing, did you have any resilience gear equipped?

Heisen59 commented 2 years ago

No, the rogue was with start-up equipment.