cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

🐛 [Bug Report] [Quest 1248] The Missing Diplomat cannot get the follow-up quest #3219

Open aleigood opened 1 year ago

aleigood commented 1 year ago

Bug Details

After defeating Tapoke "Slim" Jahn,cannot get the follow-up quest. 屏幕截图_20221122_233625

Steps to Reproduce

1.quest add 1248 2.go cr id 4963 3.beat Tapoke "Slim" Jahn and complete quest 4.talk to Tapoke "Slim" Jahn

Expected behavior

No response

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

01b98b1fa68016b7c68de3c998aebbfe1d154940

Database SHA1 Commit Hash

96b94fbb54b12b642a5de569e45014caf91b578e

Operating System

Ubuntu

Client Version

2.4.3 (The Burning Crusade)

Grz3s commented 1 year ago

@AnonXS [4427] FIX - resolves issue with 2 quests given at same time after kicking Tapoke "Slim" Jahn ... Now chain will work correct.

Also: theres another issue in this ticket that i couldnt reproduce in WotLK... Tapoke "Slim" Jahn - should despawn after q. credit. Im not sure what happened here.. but on pic. above he restored his QuestFlag .. stayin outside (this shouldnt happen) Pls check his script if smth isnt missing via backports

AnonXS commented 1 year ago

grafik

with this quest the "chaining of quests" might be smoother, but it does not fix any issue in regards with this mob in tbc core, he becomes interactable has correct npcflags but you click him an dnothing happens.

cpp is identical for both mobs in tbc and wotlk, if you kill and force respawn him he will respawn at this location instead of original spawn location, he will set orientation towards you but is not effectivly interactable.

when you restart the server, he will respawn at his original spawn location, and will be interactable.

grafik

not a db issue but strange issue regarding his core script or some general behavior in tbcmangos vs wotlkmangos. @killerwife

Setting nextquest or anything seems wrong when looking at https://www.wowhead.com/classic/quest=1249/the-missing-diplomat (unrelated)

    void JustDidDialogueStep(int32 iEntry) override
    {
        if (iEntry == QUEST_MISSING_DIPLOMAT11)
        {
            // complete quest
            if (Player* pPlayer = GetPlayerForEscort())
                pPlayer->RewardPlayerAndGroupAtEventExplored(QUEST_MISSING_DIPLOMAT11, m_creature);

            // despawn and respawn at inn
            m_creature->ForcedDespawn(1000);
            m_creature->SetRespawnDelay(2);
        }
    }

is not working correctly, he's respawned at current location and then bugged out until serve restart.