cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

🐛 [Bug Report] Lockboxes not working correctly when unlocking or after unlocked. #3306

Open MilkmanMHOC opened 1 year ago

MilkmanMHOC commented 1 year ago

Bug Details

Lockboxes are not working correctly. If rogue unlocks a box, it is no longer tradable/mail-able. Rogues can not unlock a lockbox for another player via the trade tab either. System warns "The item doesn't exist."

Steps to Reproduce

  1. Initiate a trade with a rogue and place lockbox in bottom non-trade tab
  2. Rogue trys to unlock it
  3. Doesn't work.

Or

  1. Rogue unlocks lockbox
  2. Trys to trade or mail opened lockbox
  3. Doesn't allow it

Expected behavior

Rogues should be able to unlock boxes via trade similar to how enchanters enchant items in trade window. Unlocked boxes should also be tradable after being unlocked.

Suggested Workaround

Rogues can unlock boxes and remove items and then give items to others. Hopefully you trust who your giving the box too!

Crash Log

No response

Core SHA1 Commit Hash

559c0cc4d127233ac2bae4824cc547717bed2658

Database SHA1 Commit Hash

bb2cd821d29b2a58214943c84302f6032eb8be64

Operating System

Win7

Client Version

1.12.1 (Classic)

f0n1x commented 1 year ago

Can confirm that I am seeing this behavior in Classic (1.12)

killerwife commented 1 year ago

Will be resolved by my schema changes on tbc when ported to vanilla. Bit busy at the moment but its on the way soon.

CaptainJaySolo commented 1 week ago

Also happens on 2.4.3 TBC. I tried changing some flags in the Database but no joy. It'll be in the code somewhere, I have not found it yet.