Closed Eonfluxx closed 1 year ago
Please tell me on map where you were testing :) This screenshot is not enough.
Please tell me on map where you were testing :) This screenshot is not enough.
.go xyz 7127 -7037 48 530 and spawn a creature behind the tree. Then try to cast any target spell.
For thix example
if (m_spellInfo->HasAttribute(SPELL_ATTR_EX5_ALWAYS_LINE_OF_SIGHT) || (!IsIgnoreLosSpellCast(m_spellInfo) && !m_IsTriggeredSpell)) if (!m_trueCaster->IsWithinLOSInMap(target, true)) return SPELL_FAILED_LINE_OF_SIGHT;
In Spell.cpp should have if (!m_trueCaster->IsWithinLOSInMap(target))
Classic wotlk - used ranged ability through tree to kill it.
Very much blizzlike.
Of course Blizzard did it this way to reduce the load on the servers, but it shouldn't be the case in Battlegrounds and Arenas. Casting through pillars in Nagrand Arena or stumps in Warsong is ridiculous.
That is accurate to the source material
Feel free to provide videos of arenas and battlegrounds with the evidence. This was super easy to check for me, but despite your reservations to the source, that is not a reason to change it in an emulation project.
this is on CMaNGOS. the nagrand arena is a WMO, and WMOs are not affected by the LoS ignore attribute
Correction, they can be, but are not flagged m2.
Warsong
Ok but please provide evidence it shouldnt be this way from official servers. These to my knowledge do not prevent los on official either.
In warsong this is the correct behaviour.
No bug, thats intended video from wotlk classic https://youtu.be/GYNt6bSHSY0
I would never have believed that on the official server so. Well, thank you for the answers.
Bug Details
There's some checks of
WorldObject::IsWithinLOSInMap
that using ignoreM2Model as true. When checking casting, it always ignoring client textures, including BG and arenas. Why it should be like that? It is wrong by all means.It is should be like at the screen, but it casting through.
Please, explain me why it's like that.
Steps to Reproduce
1. 2. 3. 4.
Expected behavior
No response
Suggested Workaround
No response
Crash Log
No response
Core SHA1 Commit Hash
last
Database SHA1 Commit Hash
last
Operating System
win11
Client Version
2.4.3 (The Burning Crusade)