cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 48 forks source link

🐛 [WOTLK] Morbent Fel - Unholy Shield #3581

Open al3xc1985 opened 1 year ago

al3xc1985 commented 1 year ago

Bug Details

https://www.wowhead.com/wotlk/spell=8909/unholy-shield https://www.wowhead.com/wotlk/npc=1200/morbent-fel#abilities

This NPC has a shield that makes u at this level to hit him for 1 dmg because it gives high resistances, high armor, and as I remember high regen rate in combat. But his aura doesn't do any of this

@insunaa Can I summon u just for a thought?

Steps to Reproduce

1. 2. 3. 4.

Expected behavior

No response

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

4aa81134be302fed4a22f1c2e01374e3c3

Database SHA1 Commit Hash

87d213957c5f6d4e2e3679eaf81986eb43e32525

Operating System

windows 10

Client Version

3.3.5a (Wrath of the Lich King)

insunaa commented 1 year ago

I don't pay attention to my github notifications because I get so many. If you need me say something in Discord, please.

al3xc1985 commented 1 year ago

what name do u have on Discord?

insunaa commented 1 year ago

"Mein Name ist Hase"

al3xc1985 commented 1 year ago

`void Aura::HandleAuraModResistance(bool apply, bool /Real/) { if (!m_modifier.m_amount) return;

Unit* target = GetTarget();

for (uint32 i = SPELL_SCHOOL_NORMAL; i < MAX_SPELL_SCHOOL; ++i)
{
    if (m_modifier.m_miscvalue & (1 << i))
    {
        float oldResist = target->GetTotalResistanceValue(SpellSchools(i));
        target->HandleStatModifier(UnitMods(UNIT_MOD_RESISTANCE_START + i), TOTAL_VALUE, float(m_modifier.m_amount), apply);
        float change = target->GetTotalResistanceValue(SpellSchools(i)) - oldResist;
        // UI bonus/malus info:
        target->ApplyResistanceBuffModsMod(SpellSchools(i), (m_modifier.m_amount > 0), apply ? change : -change, apply);
    }
}

}`

insunaa commented 1 year ago

There seems to be some problem with damage calculations

al3xc1985 commented 1 year ago

I will take this here 2 https://github.com/cmangos/wotlk-db/issues/978 I discovered some things about him

insunaa commented 1 year ago

The damage values seem to line up roughly with values I see from official servers

al3xc1985 commented 1 year ago

try to do a paladin, level him 32, learn all spell till 32 and combat morbent use judgement and exorcism on him and see the numbers. If those are ok, that we can close this one