🐛 [Bug Report] TBC - "The Binding" and "Call of Fire" (Alliance) do not give experience upon completion

tehmasterer commented 9 months ago

Bug Details

These two class quests, do not grant experience points for any stage of completion. "The Binding" is the warlock class quest that ends with the character getting their Voidwalker. "Call of Fire" is the shaman class quest that ends with the character getting their Fire totem.

Steps to Reproduce

Pick up the class quest.
Go through the various stages of the quest.
Expect experience points for turning in the quest.

Expected behavior

The character should be rewarded with experience if they are not max level.

Each stage of the quest gives varying amounts of experience. Below I have listed only the final stage.

"The Binding" should give 630 exp at level 10 for the final stage of the quest.
"Call of Fire" should give 840 exp at level 10 for the final stage of the quest.

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

46cbe99ea1756935e0bb109d3ddab071a7dbfc60

Database SHA1 Commit Hash

1d069d4d8ec413fe4c55efd780fb73c0ad1c4e02

Operating System

Ubuntu 22.04

Client Version

2.4.3 (The Burning Crusade)

tehmasterer commented 9 months ago

The alliance shaman quest "Call of Water" also grants no experience.

tehmasterer commented 9 months ago

The same goes for "Call of Air" and the alliance warlock class quest for the succubus.

tehmasterer commented 8 months ago

Add the alliance warlock felhunter quest to the list.

miraco commented 8 months ago

Do you have any evidence for this? and can you give us quest id + amount of xp for all quests where it’s missing

evil-at-wow commented 8 months ago

Just to add the parts I'm confident about (by playing Classic on the reference myself) and where I have some proof I can't just share here:

Quest The Binding (voidwalker) gave my lvl 13 gnome warlock 625 XP. I can't say what XP a lvl 10 should get, but it seems wowhead's scaling seems off a bit @ lvl 13.
Quest The Binding (felhunter) gave my lvl 42 gnome warlock 250 XP (I was not in a hurry to get a Felhunter as you can see).
Quest The Binding (succubus) is one I did at 60 (I only needed it for raid so even less in a hurry). Naturally in Classic completing quests at 60 doesn't give any XP, but I got 7 silver 20 copper instead, so again pretty sure it gives XP.

So at least for these, I can confirm there should be experience. The exact amounts on the other hand...

tehmasterer commented 8 months ago

@evil-at-wow already linked the warlock quests. Wowhead notes exactly how much experience you should get, depending on your level. These quests have always given experience, it's nothing to do with WoW Classic or TBC Classic.

Shaman class quests: Call of Fire Call of Water Call of Air

If necessary, I can quickly create a character with GM commands and start one of these quests, completing a stage or two. All a screenshot is going to show is no experience gained when the quest is turned in.

miraco commented 8 months ago

@evil-at-wow already linked the warlock quests. Wowhead notes exactly how much experience you should get, depending on your level. These quests have always given experience, it's nothing to do with WoW Classic or TBC Classic.

Shaman class quests: Call of Fire Call of Water Call of Air

If necessary, I can quickly create a character with GM commands and start one of these quests, completing a stage or two. All a screenshot is going to show is no experience gained when the quest is turned in.

But wowhead is in most cases not a good source of proof. If you see the first quest evil mentioned he got 625 xp with lvl 13, wowhead says it should give 630 xp. 5 xp isn’t a big difference but still is a diff.

That’s why we need good proofs before fixing it.

evil-at-wow commented 8 months ago

Another data point: doing The Binding with a lvl 12 Orc warlock gave 650 XP in Classic, while wowhead mentions 660 XP.

I'm really wondering why wowhead's XP numbers are off a little bit. For the first quest above with the lvl 13 warlock, they also list 500 xp and 250 xp for the 80% and 40% points respectively but interestingly enough that doesn't match their starting 630 xp but does match my 625 xp! Their 380 xp 60% point does match with their 630 xp though. At first I was thinking they simply captured the wrong data, similar to how so many vendor prices are wrong because they don't cancel the effects of reputation discounts, but I can't think of any reasons why XP would have been buffed for a player in Classic. And even if that was the case, it doesn't explain a 5 or 10 XP difference on top of 625/650. Instead I'd expect like a difference of 5% or 10% (taking retail XP buffs as an example) which is not the case. Very weird...

tehmasterer commented 8 months ago

Call of Water - Wowpedia Call of Water - Warcraft Wiki Call of Water - WoWWiki Fandom

Here are three other sources I can link for comparison. All three sites are basically identical and give the same numbers as Wowhead.

I haven't played retail in over a decade, so I can't say why there is a slight difference in numbers between Classic and what is on Wowhead. All I know is that I did these quests in the past and know for sure they gave experience.

tehmasterer commented 8 months ago

The level 10 Alliance warrior class quest can be added to the list. No stage of the quest grants experience when it should.

war1 war2

tehmasterer commented 6 months ago

The quest Rage of Blood, which is part of the warlock Dreadsteed quest can be added to the list.

tehmasterer commented 5 months ago

The quest The Islander, and its followup, can be added to the list. This is the warrior class quest to gain Berserker Stance.

gregclout commented 2 months ago

If wowhead and other long-term online sources aren't determined to be good enough metrics for what experience should be awarded, what is the desired or expected level of proof required?

miraco commented 2 months ago

If wowhead and other long-term online sources aren't determined to be good enough metrics for what experience should be awarded, what is the desired or expected level of proof required?

The best would be a video from original classic/tbc else, video from classic/tbc-classic or better sniffs.

I have 2 more points on my list, after this im gonna invest some time into this with the information we currently have from here.

AnonXS commented 2 months ago

For our classic branch it would be interesting to see the diff with vmangos at this point as they corrected alot of data in this regard.

cmangos might have some issues with down/upported quest exp rewards.

miraco commented 2 months ago

I added xp to the reported warlock and warrior quests https://github.com/cmangos/tbc-db/commit/7ba92a35d37c42ab1d0eb57309278ee6523ed18c

If you find any other quests that lack XP pls report it in here, will let this issue open for now. When reporting pls add atleast following Information: QuestID and Quest Name

If there are multiple quests in the chain pls also list them, ty.

For the shaman quests this will be rly tricky. There are multiple values in the internet, for example: Call of Fire (draenei, 2) different sources for level 10 WoWhead XP: 840 wowpedia: 85XP

AnonXS commented 2 months ago

grafik

https://www.youtube.com/watch?v=_VqQUD17H1k&t=580s&ab_channel=Para

but yea def tricky: https://wowpedia.fandom.com/wiki/Call_of_Fire_(Draenei,_2)?oldid=1382990

and maybe these breadcrumbquests on these chains dont give exp maybe?

cmangos / issues