cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

🐛 [Bug Report] The debuffs released by different organisms will stack up #3642

Open zw-su opened 9 months ago

zw-su commented 9 months ago

Bug Details

微信图片_20231228001250

Steps to Reproduce

  1. Skill 12541 released by different individuals of bioid 8532 will stack up

Expected behavior

No response

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

5609abafaf7b0a3ad3c302e4a9ded293fe1e4533

Database SHA1 Commit Hash

a8e3ee243e20246e79a99eb41c405955daa7ad5d

Operating System

ubuntu 22.04

Client Version

1.12.1 (Classic)

AnonXS commented 9 months ago

Any proof that this should not stack individually?

temp solution:

-- https://github.com/cmangos/issues/wiki/spell_template#attributesex
-- SPELL_ATTR_EX_AURA_UNIQUE
UPDATE `spell_template` SET `AttributesEx` = `AttributesEx`|0x00000800 WHERE `Id` = 12541; -- Ghoul Rot
insunaa commented 9 months ago

I've seen this happen on the reference, so I think this is working as intended.

zw-su commented 9 months ago

Thank you very much for your answers. If these debugs stack on me more than 2, making it almost impossible to hit creatures, I don't think it's a good gaming experience, and I tested it in vmangos, it only updates time and doesn't stack.

AnonXS commented 9 months ago

other emulator does not count as proof, we need atleast classic proof.

/edit: this should be discussed as cmangos has ripped out most of the aura stacking code and we should start investigating solutions, cases going forward.

zw-su commented 9 months ago

UPDATE spell_template SET AttributesEx = AttributesEx|0x00000800 WHERE Id = 12541; After testing, it is correct. I think my problem has been solved

miraco commented 9 months ago

UPDATE spell_template SET AttributesEx = AttributesEx|0x00000800 WHERE Id = 12541; After testing, it is correct. I think my problem has been solved

Before we can close the issue completely, we need an official source that this debuff can’t stack, and like anon said other emulators are not proof for anything.

Best would be to find a video from original vanilla or test this on classic wow. Then we can officially merge this change