search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

🐛 [Bug Report] TBC - Warlock's Affliction talent "Soul Siphon" does not work #3649

Open tehmasterer opened 6 months ago

tehmasterer commented 6 months ago

Bug Details

My warlock has 2/2 ranks in the talent "Soul Siphon" but I receive none of the bonuses from said talent. My Drain Life spell only does its base damage, when it should be doing much more with 2 ranks in the talent and my affliction spells applied to the target.

Soul Siphon Rank 2 Talent Requires Warlock Increases the amount drained by your Drain Life spell by an additional 4% for each Affliction effect on the target, up to a maximum of 60% additional effect.

soul-siphon-bug

Steps to Reproduce

  1. Apply Affliction dots to enemy
  2. Cast Drain Life
  3. Drain Life only does its base damage. 61 in this case at level 48.

Expected behavior

The bonuses applied from the talent.

Suggested Workaround

n/a

Crash Log

No response

Core SHA1 Commit Hash

46ce862172aee1d1ff969f33e20374c3c869d40b

Database SHA1 Commit Hash

5914db5509a28a4ead85a117096cb18bf0aad613

Operating System

Ubuntu 22.04

Client Version

2.4.3 (The Burning Crusade)

LEO33SoFo commented 6 months ago

Confirmed, with https://github.com/cmangos/mangos-tbc/commit/3615f1ce6128270de85ef2d7ff78d02f86cf9e40 and https://github.com/cmangos/tbc-db/commit/4b654fbf0f2c2efeb295622954d6fe772d1035a5. Though in my case with Drain Life (Rank 8).

cpevors commented 6 months ago

Also confirmed for me. On my Human and Undead Warlock, at all ranks of Drain Life, Soul Siphon does not increase Drain Life damage above base damage.

miraco commented 6 months ago

This Talent afaik got scripted here: https://github.com/cmangos/mangos-tbc/blob/09471171b320959091716ff457938dc9ae5c630d/src/game/Spells/Scripts/Scripting/ClassScripts/Warlock.cpp#L422 But it seems that the check for SpellFamilyFlags fails, thats why it doesnt update the correct % to Drain Life spell