cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 47 forks source link

🐛 [Bug Report] Razorgore Mind Exhaustion debuff #3714

Open Vigerus opened 6 months ago

Vigerus commented 6 months ago

Bug Details

Razorgore (BWL) debuff "Mind Exhaustion" is not working properly.

Steps to Reproduce

  1. Go to BWL with minimal team
  2. Kill the adds, click on the orb
  3. You will see the "Mind Exhaustion" debuff straight away.
  4. The debuff wears earlier than the MC so you can click again as soon as the first MC is over.

Expected behavior

Razorgore (BWL) debuff "Mind Exhaustion" should be applied when channel is over or when the player dismisses Razorgore early. Right now it is applied upon use which makes this mechanism trivial.

Suggested Workaround

boss_razorgore.cpp:

PossessRazorgore::OnApply: if (Unit* caster = aura->GetCaster()) caster->CastSpell(caster, SPELL_MIND_EXHAUSTION, TRIGGERED_OLD_TRIGGERED);

this piece should be moved to another event section

Crash Log

No response

Core SHA1 Commit Hash

0e32ab652f9b44868bdadf99638002faca426c9d

Database SHA1 Commit Hash

8cd7a968410c46bf36519c94e6c19781ff52a234

Operating System

Windows 10 Enterprise

Client Version

1.12.1 (Classic)

al3xc1985 commented 4 months ago

was this fixed?

cpevors commented 4 months ago

It was fixed in this commit: https://github.com/cmangos/mangos-classic/commit/4a3e2845458935721a8f16103d9592da15370b64

ileboii commented 1 month ago

This change is based on how it works in Season of Discovery (or other modern versions of World of Warcraft), not how it was back in the original 2005 vanilla version of the game.

The debuff is supposed to be applied when Mind Control begins.

The original intended mechanic behind the debuff was not about swapping players doing the MC, but to prevent a designated player Mind Controlling Razorgore cancelling their cast prematurely. MC swap as a mechanic did not exist in any shape or form back in the original vanilla World of Warcraft, not with Razorgore or any other encounters found in the game.

This is a newly introduced mechanic for todays standards in increased raid difficulty for Season of Discovery, which is why you see the debuff being applied after the MC ends in the modern version.

However, this should not apply in CMaNGOS as it is supposed to emulate the original 1.12 version.

Sources: https://www.youtube.com/watch?v=YrgSPwH1QMc - Self explanatory, debuff is applied to the player Mind Controlling Razorgore at the instant they touch the orb.

https://www.youtube.com/watch?v=Mjc1DtxgBz8 - The same Mage player is Mind Controlling Razorgore repeatedly.

https://www.youtube.com/watch?v=JHSGNlx56Fc - In this video the debuff icon is shown below the Razorgore's raidframe, possibly due to addons, but it is there when the player begins MC. And they are Mind Controlling Razorgore repeatedly.

al3xc1985 commented 1 month ago

@AnonXS can u take a look and reopen the issue if nedded?

Vigerus commented 1 week ago

PR: https://github.com/cmangos/mangos-classic/pull/586