cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

šŸ› [Bug Report] Negative hit points on levelup #3715

Open katz1 opened 4 months ago

katz1 commented 4 months ago

Bug Details

While gaining level 11 as a Human Warrior, the chat log message said: You have gained -1 hit points.

image

I can't say if my health actually reduced or not, and I never paid attention to the messages at previous level ups.

Steps to Reproduce

  1. Gain level 11 as a Human Warrior

Expected behavior

No response

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

0e32ab652f9b44868bdadf99638002faca426c9d

Database SHA1 Commit Hash

6885b120d8ef9338359ddf462239d8de27e679ee

Operating System

Windows 10

Client Version

1.12.1 (Classic)

cpevors commented 4 months ago

This issue persists on TBC as well -- and, indeed, you do lose the 1 Hit Point. Below are screenshots of my character at level 10 and again at level 11. While, from 10 to 11, I gained 1 Stamina, my overall health only went up 9 HP, i.e. 1 Stamina --> 10 HP less the 1 Hit Point I was stated to have lost in that level-up process.

Level 10: WoWScrnShot_051524_171533

Level 11: WoWScrnShot_051524_171549

I consulted the DB. The issue is in the player_classlevelstats table -- where, from 10 to 11, Warrior's basehp does, in fact, go down from 101 to 100. As such, this issue affects all Warriors of any and all Races.

image

I did a quick analysis of this table, and I found that this issue persists for Class 2 as well. From Level 14 to 15, basehp goes from 132 to 131.

There are analogous errors in basemana for the following:

Class 8, Level 2-3 - basemana goes from 110 to 106. Class 8, Level 5-6 - basemana goes from 131 to 130. Class 9, Level 3-4 - basemana goes from 107 to 102.

katz1 commented 4 months ago

I am actually not 100% sure if this is a bug now. I have a sense of deja vu that I reported the same issue 10 years ago and I was told this is how it used to work in classic.

cpevors commented 4 months ago

Iā€™m quite old and my memory is quite trash, but that isnā€™t my recollection of Classic at all. There are instances where your base hp or base mana or your stats donā€™t increase upon level up, but I canā€™t recall a single time even on Classic Era servers where I was punished in some way for leveling.

May hop on a Classic Era server to test this out. Level 11 isnā€™t a huge time investment, and some of the other anomalies I noted are at even lower levels.

Iā€™ll report back as soon as Iā€™m able.

katz1 commented 4 months ago

The message is misleading. Your total health didn't actually go down based on your screenshots. I assume because the +1 stamina gives +10 hit points. The message reports -1 because the base health did go down.

I think it is possible that all the current hit points and mana values are correct, but the message does not account for the stamina / intellect increment. This may or may not be a bug.

cpevors commented 4 months ago

The message about your health points going down by 1 only refers to your base health points. It has nothing to do with stamina, as the increase is stamina is noted elsewhere.

I do not think the basehp should be going down from one level to the next. I haven't had a chance to fire up Classic Era, but it's on my docket for this week.

killerwife commented 4 months ago

Just want to state that I have no data on this and have never in my tenure checked those tables out nor has anyone altered them since im here. There might very well be a data mistake but please if u will be changing anything, research it.

cpevors commented 4 months ago

Whatā€™s the preferred way of remitting sniffs?