cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
180 stars 47 forks source link

🐛 [TBC] Debuff time wrongly showed #3766

Open al3xc1985 opened 2 months ago

al3xc1985 commented 2 months ago

Bug Details

After a discussion on discord, between @insunaa and @Ioanit, I will post some info, and hope Ioanit will add what I missed Quote : ". The debuff icon shows that the effect has ended, but the time correctly displays the effect of the debuff. This happens on all mobs. At first, the debuff is displayed correctly. Then, after a few hits, it stops updating. If you apply another effect, the debuff will update again, but after a few hits, it will stop again."

https://cdn.discordapp.com/attachments/694883180292866048/1282436838958567556/gif.gif?ex=66e002a0&is=66deb120&hm=7340e9a2747fb6b1d1b3b48364447aaab896991ee1ccf2cc72e4b8f3498ab4ba&

And @insunaa patch was this one ''patch diff --git a/src/game/Spells/SpellAuras.cpp b/src/game/Spells/SpellAuras.cpp index 892ae684c..aeb28be79 100644 --- a/src/game/Spells/SpellAuras.cpp +++ b/src/game/Spells/SpellAuras.cpp @@ -8347,7 +8347,7 @@ void SpellAuraHolder::Update(uint32 diff) void SpellAuraHolder::RefreshHolder() { SetAuraDuration(GetAuraMaxDuration());

The patch worked as @Ioanit tested it But his concern of this being the write way of fixing the problem is limited

Steps to Reproduce

1. 2. 3. 4.

Expected behavior

No response

Suggested Workaround

No response

Crash Log

No response

Core SHA1 Commit Hash

4aa81134be302fed4a22f1c2e01374e3c3

Database SHA1 Commit Hash

87d213957c5f6d4e2e3679eaf81986eb43e32525

Operating System

windows 10

Client Version

2.4.3 (The Burning Crusade)