Defender of the Timbermaw bugged

[zwisus]

This trinket (http://www.wowhead.com/item=21326) is rewarded from the Timbermaw faction once you reach exalted with them, and is currently not working as intended.

What it currently does:

A Timbermaw Ancestor (http://old.wowhead.com/npc=15720#comments) is spawned for 30 seconds. It acts like an aggressive combat pet and melees for about 40 damage per hit.

What it should do:

The timbermaw ancestor should have two spells, lightning bolt and healing wave. From a quote on wowhead:

-It seems to have ~500 hp -It is level 60, but isn't very tough even versus lower level melee -It seems to heal you ONLY if you drop below 50% HP, and this also seems to be subjective to if it's attacking something or not. You can exert some control over this by ensuring that all targets around you are CCd when you want it to heal you. As a rogue I blind, then gouge and start a bandaid while he casts a heal. -I've seen it's heals range from 200-900 however I wasn't paying attention to mortal strike or critical heals. -It spams a lightning bolt that is ~2 second cast time for 250 damage. -It will not attack anything unless something attacks you while it's summoned, however it will heal if there are no enemies around and you are under ~50% -It is obtainable for a level 49 (my 49 rogue has it, and i don't use it that often.)

The wowhead website does not list the timbermaw ancestor's spell abilities, however I doubt the commentator made up his experiences. Perhaps because the trinket is so old, wowhead doesn't have accurate data. These spells (http://old.wowhead.com/spell=23381 , http://old.wowhead.com/spell=15234 ) seem to fit the description of what the timbermaw ancestor should use.

I know that this is a very niche trinket that not many people will get, however it takes a collosal effort to reach exalted with the timbermaw faction and it's unfortunate that the trinket rewarded at the end of the grind is bugged.

[cyberium]

Not 100% sure but afaik its not a core issue. If so i prefer you post this on the forum instead. (ACID ?)

@Schmoozerd could you confirm this and close it if its the case?

[Schmoozerd]

hmm, scripting pets is probably best done by sd2 in this case.

poke @xfurry Maybe we should add a new file in sd2 for generic pets (as there are many "special" pets that behave individually. Also as luda is away and NF no more active we can now finally safely implement exploding sheeps Everybody loves sheeps! ;)

[xfurry]

Well... isn't Acid good enough for this one? What is so special about it that it requires SD2 scripting?

Also, this summon is a Guardian Pet, and guardian pets currently do not have get any AI assigned (don't ask me why), so I don't think it will work either way.

[ghost]

Found one feature.

Id: 63774 Name: Призыв элементаля огня Description: Призывает $s1 $lэлементаля огня, помогающего:элементалей огня, помогающих; заклинателю до тех пор, пока он не откажется от сопровождения. General info Category = 0, SpellIconId = 876, ActiveIconId = 0, SpellVisual = (1267, 0) SpellFamilyName = SPELLFAMILY_GENERAL, SpellFamilyFlags = 0x00000000 00000000 00000000 SpellSchoolMask = 4 (SCHOOL_MASK_FIRE, SCHOOL_MASK_SPELL, SCHOOL_MASK_MAGIC, SCHOOL_MASK_ALL) DamageClass = 0 (SPELL_DAMAGE_CLASS_NONE) PreventionType = 0 (SPELL_PREVENTION_TYPE_NONE) Attributes Attributes: 0x10000010 (SPELL_ATTR_UNK4, SPELL_ATTR_CANT_USED_IN_COMBAT) Advanced info Spell Level = 80, BaseLevel 80, MaxLevel 0, MaxTargetLevel 0 Category = 0 DispelType = 0 (DISPEL_NONE) Mechanic = 0 (MECHANIC_NONE) SpellRange (Id 1) "Self Only" MinRange = 0 MaxRange = 0 CastingTime (Id 1) = 0.00 Duration: ID (21) -1, 0, -1 Interrupt Flags: 0x00000009, AuraIF 0x00000000, ChannelIF 0x00000000 Chance = 0, charges - 0 Effects Effect 0: Id: 28 (SPELL_EFFECT_SUMMON) BasePoints = 0 Targets (32, 0) (TARGET_MINION, NO_TARGET) EffectMiscValueA = 33838 EffectMiscValueB = 1721 Effect 1: NO EFFECT Effect 2: NO EFFECT Here is an example of a pet. If it summon the NPC, then EventAI preserved pet behaves as scripted by EventAI. If it summon a player, he has also PetAI. A Movefollow for Summoner EventAI not assign unfortunately (need no function)

[cala]

I dug this issue there are two things to fix:

• the pet stats: this is a core issue where the NPCs uses precalculated data instead of its DB data and @cyberium is already working on a nice patch regarding it
• the pets behaviour, @xfurry is right, ACID is enough for this and I should make a PR about it soon.

[Phatcat]

I dug this for a much more horrible thing to fix: EventAI doesn't work for player summoned guardians. Don't ask me why.

Precalculated stats is taken care of, this guardian is summoned with appropriate stats (if that insanely high mana is to be considered correct) this is sadly still a core issue, otherwise we could have closed this.

[cala]

Closed by: https://github.com/cmangos/mangos-classic/commit/e4bdd72b909066f7fc163c62439334ee96d49748 and https://github.com/ACID-Scripts/Classic/commit/6d27ef20fa3527250a204a250cc8f52e8bd3bcf9 (there similar commits for TBC and WotLK branches). Thanks @cyberium and @Phatcat for their work on the matter.