search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

WotLK+Cata: Command: .gobj tar / .npc info crashing server #617

Closed NightSharky closed 7 years ago

NightSharky commented 9 years ago

When i use .gobj tar on any object which is in game_event_gameobject table. Server crashed.

The same also for .npc info if creature is in event.

virusav commented 9 years ago

WOTLK, core - 12852, SD2 - 3114: none of the commands has not led to crash the server.

VladimirMangos commented 9 years ago

In 99% cases command crash server in result wrong/outdated localization strings for specific command output. I suggest check its, or check crash case with english localization.

NightSharky commented 9 years ago

WotLK: rev. 12846, UDB Cata: rev. 13062, UDB Localization strings are ok.

evil-at-wow commented 9 years ago

I can confirm the crash with my TBC repository, even with the default English strings.

Are you running Linux too by any chance? If so, what compiler (and version) are you using?

VladimirMangos commented 9 years ago

Hmm... this commands share code at call ChatHandler::ShowNpcOrGoSpawnInformation but i not see possible problem in it or related db strings.

xfurry commented 9 years ago

@evil-at-wow Does this issue still happen? I can't reproduce it on master.

evil-at-wow commented 9 years ago

Yes, this still happens, at least on my Linux system. I'll have to do some more serious debugging instead of a quick look, because the passed strings and format specifiers look just fine to me, yet one of those variable argument calls goes into 'bigga badaboom' mode for some reason...

xfurry commented 9 years ago

Please give me some example on how to crash the server. That would make it easier for me to understand.

evil-at-wow commented 9 years ago

As GM, just target any NPC that's associated with an event, and run .npc info on it.

If you want a sequence of commands, then run the following commands as GM after logging in:

.event start 1
.go creature id 16781
/tar Midsummer
.npc info

After the last command, my server goes :boom:

NightSharky commented 8 years ago

I have tested a little bit. And if i cmake source with -DDEBUG=0, it will crash on commands (.gobject target, .npc info). But if i use -DDEBUG=1, its ok and working fine.

cyberium commented 7 years ago

Iam not able to replicate it nor seeing what could cause this. Iam closing this but feel free to provide more replication way if any and we'll reopen it.

Warlockbugs commented 7 years ago

The vararg types issue i fixed in all pre-cata cores a few months ago. Should be closed.