CMake build fails on windows using VS2010

cmangos-bot commented 11 years ago

Created by @DasBlub on 2013-02-24 11:29:43

the build on windows with CMake fails due to problems with ACE. build on linux works fine. also, building with the shipped VC files works fine. i ran the following command to configure CMake: cmake -G "Visual Studio 10 Win64" -DPREFIX=_install -DPCH=1 ..

[...]
"e:\wow-dev\mangos-wotlk\_build\ALL_BUILD.vcxproj" (default target) (1) ->
"E:\wow-dev\mangos-wotlk\_build\src\mangosd\mangosd.vcxproj" (default target) (14) ->
(Link target) ->
  LINK : fatal error LNK1104: cannot open file 'ACEd.lib' [E:\wow-dev\mangos-wotlk\_build\src\mangosd\mangosd.vcxproj]

"e:\wow-dev\mangos-wotlk\_build\ALL_BUILD.vcxproj" (default target) (1) ->
"E:\wow-dev\mangos-wotlk\_build\src\realmd\realmd.vcxproj" (default target) (15) ->
  LINK : fatal error LNK1104: cannot open file 'ACEd.lib' [E:\wow-dev\mangos-wotlk\_build\src\realmd\realmd.vcxproj]

    17 Warning(s)
    2 Error(s)

cmangos-bot commented 11 years ago

Comment by @DasBlub on 2013-02-25 10:08:38

so, after wasting a whole evening with trying to fix the ExternalProject_Add command for ACE i came to the conclusion that this is not the correct way. so now i'm going to write a CMakeLists.txt for ACE, this'll work and also make the ExternalProject_Add command for UNIX unnecessary, too. we already have CMakeLists.txt for most other dependencies, so this can't hurt.

this should also speed up compile on all systems when building the ACE version in dep/ACE_wrappers.

i'll do it in the next few days...

cmangos-bot commented 11 years ago

Comment by @DasBlub on 2013-02-25 10:36:32

if anyone cares: this was my failed attempt: https://gist.github.com/DasBlub/5033971 the main problem now is, that it does not take the same build configuration (Debug/Release & win32 / x64) as the rest of the build.

cmangos-bot commented 11 years ago

Comment by @DasBlub on 2013-03-01 11:39:04

so this is totally messed up. :( i spent quite some time to build a CMake file for ACE but it does not work. i can get ACE to compile fine, but as soon as i try to link mangosd & realmd to ACE it'll fail. also, there is a lot of logic in ./configure and we're missing out on that when we're not running it and it'll cause the ACE build to fail sometimes. also, i was unable to build a new (latest microrelease), clean, ACE with CMake files on linux. and i was unable to build the current one on windows (even though i was able to build it on linux).

so back to square one. the current try is to use include_external_msproject on windows, but that one adds the project with the type UTILITY and not STATIC, so we can't link against it.

if anyone comes up with a good idea (best: CMake file(s) for linux AND windows, 2nd: mixed support (msproject for windows, CMake for linux), 3rd: ExternalProject_Add), go ahead and create a patch and post it here!

cmangos-bot commented 11 years ago

Comment by @rsa on 2013-03-02 05:04:23

your problems are not well understood. If you want to build ACE under windows using gcc, you'll need to patch the ACE. But the assembly under *nix works fine in all cases (of course, if you do not it yourself broke :) - in R2 long time build maked only over cmake, all works...

cmangos-bot commented 11 years ago

Comment by @Lillecarl on 2013-03-02 09:54:52

@rsa You are evil! :P

cmangos-bot commented 11 years ago

Comment by @DasBlub on 2013-03-04 11:15:33

ok, so i finally got it working! https://github.com/DasBlub/mangos-wotlk/commit/b563baa9f3e05149adcc8a9bb8da042f5c6a569a

i did not push this to upstream yet because i first need to clean things up and make sure that i didn't break linux compile :)

does anyone know whether those hacks for xcode are still required?

cmangos-bot commented 11 years ago

Comment by @faramir118 on 2013-03-05 03:50:46

which xcode hacks?

cmangos-bot commented 11 years ago