search

cmangos / issues

This repository is used as a centralized point for all issues regarding CMaNGOS.
179 stars 47 forks source link

MaxPrimaryTradeSkill / CONFIG_UINT32_MAX_PRIMARY_TRADE_SKILL Capped At 10 #917

Closed Enverex closed 5 years ago

Enverex commented 8 years ago

This value has a hard-limit of 10 which was fine for Vanilla and BC, but WotLK has 11 skills meaning it's insufficient if someone wants to set a "allow all skills" value.

Is there any reason CONFIG_UINT32_MAX_PRIMARY_TRADE_SKILL cannot be set to a max of 11 rather than 10?

If not, then it's a simple case of updating https://github.com/cmangos/mangos-tbc/blob/master/src/game/World.cpp#L542 and the comment lines in mangos.conf.

Enverex commented 8 years ago

I rebuilt with CONFIG_UINT32_MAX_PRIMARY_TRADE_SKILL set to an allowed max of 11 and haven't ran into any so far, the game has successfully allowed me to learn 11 skills.

jimmybrancaccio commented 5 years ago

Closing this one out as per last comment. Please open a new issue with full details if you're still experiencing any problems. Thanks!