Closed dllahr closed 6 years ago
dllahr
commented
6 years ago That's standard directory structure for tests we've used everywhere else in CMap. I'm not a fan / actively opposed to just dumping everything in one directory, I like to keep things organized by test module and test method.
oena
commented
6 years ago Ok, that's definitely fair (particularly for testing files); looking more closely at these I think they should be fine with previous structure. My original concern was that I set up Travis to run every test_*.py file in each tests directory, and if there are subdirectories that would at minimum need to be adjusted. But turns out that's not applicable here
dllahr
commented
6 years ago FYI / to be clear - the test modules - the python code running the tests - is not in subdirectories. It is just the resources under functional tests that is now structured. Right?
oena
commented
6 years ago Right.
On Thu, Oct 26, 2017 at 4:54 PM Dave Lahr notifications@github.com wrote:
FYI / to be clear - the test modules - the python code running the tests - is not in subdirectories. It is just the resources under functional tests that is now structured. Right?
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/cmap/cmapPy/pull/12#issuecomment-339797923, or mute the thread https://github.com/notifications/unsubscribe-auth/AHs475_grmU0UtaW5JflZZRkjz0aUldcks5swPGagaJpZM4P-H1N .
-- Sent from Gmail Mobile; apologies for typos.
levlitichev
commented
6 years ago This can close issue 9, right?
@dllahr And one more slightly more general question-- I'm curious as to why you updated the testing directory structure for the main method to include several subdirectories within pandasGEXpress/tests?
Also the diffs were a little confusing to look at--some files were entirely highlighted but the content looked the same to me for some reason--so if I didn't look closely enough at something let me know.