Closed JDRomano2 closed 6 years ago
Hi @JDRomano2, thanks for your contribution! However, in order to accept your PR and merge to master the test suite config would actually need to be modified to also run all of our tests using Python 3 in addition to Python 2 (which--if you look at the config on Travis CI--it currently isn't); this would require some additional changes.
Unfortunately, there seem to be other Python 3 compatibility issues that prevent the test suite from passing. I'm going to close the PR and work on Python 3 compatibility on a new local branch (so I don't pollute the commit log on master
), and resubmit as a new PR later once everything is running properly.
I've also noticed that #24 contains discussion about outstanding issues with Python 3, so I'll make sure that I'm not just reinventing a broken wheel 😄.
Thanks for your responsiveness!
Sounds good, thanks @JDRomano2!
When trying to parse a GCT file using
cmapPy.pandasGEXpress.parse.parse()
in Python 3, the following error raises:In Python 3, this error occurs when a file is read as binary (e.g.,
open('foo.bar', "rb")
when it shouldn't be. This patch resolves the issue by testing the python version and using the correct flag withinopen()
.