cmars / tfclient

tensorflow_serving inception gRPC client
Apache License 2.0
12 stars 3 forks source link

Fail to build with protoc 3.1.0 #2

Closed tobegit3hub closed 7 years ago

tobegit3hub commented 7 years ago

Now I clone the project in my $GOPATH and try to build. It fails and the error log looks like this.

➜  tfclient git:(master) go build
# github.com/cmars/tfclient/vendor/tensorflow_serving/apis
vendor/tensorflow_serving/apis/prediction_service.pb.go:27: undefined: grpc.SupportPackageIsVersion3

And the version of protoc is 3.1.0 which should support protobuf 3.

➜  tfclient git:(master) protoc --version
libprotoc 3.1.0

I can go build if I comment out that line of code. But I'm still confused about how to run this. Do you mind adding more introduction about compiling and usage?

radekdymacz commented 7 years ago

+1

cmars commented 7 years ago

Ok, ok, I'll try to look at this soon! :) In my haste, I lost the commands I used to create the protobuf shims, so this will be a fun rediscovery process..

ilaripih commented 7 years ago

I compiled the latest .proto files with protoc 3.1.0 and created a fork in case someone's interested: https://github.com/ilaripih/tfclient

cmars commented 7 years ago

Merged. Thanks @ilaripih !