Closed aaa34169 closed 5 years ago
Thank you Fabien! :smiley: I'm on holiday at the moment (for Easter :hatching_chick:) but when I'm back on Tuesday I will review and merge!
you re welcome As i said, i also have R code based on spreadsheet i generate from pyCGM2. I need to tidy up first.
Hi Fabien,
A few requests before we merge your code:
Could you change the name of the SEM folder to Standard_error or something more descriptive like that? (You can see I've named the GPS folder Gait_profile_score. I don't want to assume people know what these acronyms mean.)
Could you include a readme.md file in the c3d IO folder to explain what the BTK Python package is, and how to install it? (The cheat sheet is great for people who are already a bit familiar with Python and packages, but we want to make sure complete beginners can use the code too :smiley: )
It would also be great to include the "script for starting" (which is in the bottom of the cheat sheet) as a separate file that people can instantly modify and use. If you could do all three examples (plot, filter, rotation matrix) as separate files that would be even better :100:
:tada: Thank you! :tada:
I made modifications : -)
Hi Dimitra, I leave you accept my pull request. Normally, it automatically points to the updated commit.
Hi Fabien, so sorry about the delay, I've been swamped with other things :weary: I will look through your code by Friday at the latest!
no worries
Le mer. 8 mai 2019 à 17:23, Dimitra Blana notifications@github.com a écrit :
Hi Fabien, so sorry about the delay, I've been swamped with other things 😩 I will look through your code by Friday at the latest!
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cmasuki/open-code/pull/14#issuecomment-490554826, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXUMBJETUZIWFRFPPVLX4DPUL5ATANCNFSM4HHANXQA .
Fabien Leboeuf
In this 1st pull request, i share
my cheat sheet of Btk ( Biomechanical toolkit), explaining how you can access and write information into a c3d in python 2.7.
It would be great if a contributor could propose a Matlab cheat sheet :smirk:
Pr Richard Baker 's spreadsheet on calculation of the Standard Error of measurement.