search

cmateu / galstreams

Milky Way Streams Footprint Library and Toolkit for Python
BSD 3-Clause "New" or "Revised" License
46 stars 17 forks source link

Sgr model in repo seems to be from L05 and not L10 #3

Closed rohannaidu closed 1 year ago

rohannaidu commented 6 years ago

Thanks for this super useful package and the beautiful plotting tools!

A potential issue: the file defining Sgr that lives here seems to be from the 2005 spherical models and not the updated triaxial 2010 models. Is the Sgr footprint seen in your example plot generated from this spherical 2005 file? If so, it'd be good to modify the labels to reflect that this is L05, or better, update the footprint to the triaxial potential!

cmateu commented 6 years ago

Hi Rohan,

Sorry for the delayed reply. Thanks for making me note this. Indeed, the label is wrong, the model being used right now is the spherical one from Law+ 2005 (rather than 2010).

Ideally I’d like to add an option for the user to choose between the different Sgr models available.

For now, I’ll update the file to match the label.

Thanks!

On May 14, 2018, at 8:11 PM, Rohan Naidu notifications@github.com wrote:

Thanks for this super useful package and the beautiful plotting tools!

A potential issue: the file defining Sgr that lives here https://github.com/cmateu/galstreams/blob/master/galstreams/lib/lib_by_star.sgr.law10_spherical.dat seems to be from the 2005 spherical models and not the updated triaxial 2010 models http://faculty.virginia.edu/srm4n/Sgr/data.html. Is the Sgr footprint seen in your example plot generated from this spherical 2005 file? If so, it'd be good to modify the labels to reflect that this is L05, or better, update the footprint to the triaxial potential!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cmateu/galstreams/issues/3, or mute the thread https://github.com/notifications/unsubscribe-auth/AEvQiPvcBEQdindfwEbSAo_hXUhicP08ks5tyg8PgaJpZM4T-pw6.

rohannaidu commented 6 years ago

Thanks for looking into it!

On 22 May 2018 at 11:04, Cecilia Mateu notifications@github.com wrote:

Hi Rohan,

Sorry for the delayed reply. Thanks for making me note this. Indeed, the label is wrong, the model being used right now is the spherical one from Law+ 2005 (rather than 2010).

Ideally I’d like to add an option for the user to choose between the different Sgr models available.

For now, I’ll update the file to match the label.

Thanks!

On May 14, 2018, at 8:11 PM, Rohan Naidu notifications@github.com wrote:

Thanks for this super useful package and the beautiful plotting tools!

A potential issue: the file defining Sgr that lives here < https://github.com/cmateu/galstreams/blob/master/ galstreams/lib/lib_by_star.sgr.law10_spherical.dat> seems to be from the 2005 spherical models and not the updated triaxial 2010 models < http://faculty.virginia.edu/srm4n/Sgr/data.html>. Is the Sgr footprint seen in your example plot generated from this spherical 2005 file? If so, it'd be good to modify the labels to reflect that this is L05, or better, update the footprint to the triaxial potential!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub < https://github.com/cmateu/galstreams/issues/3>, or mute the thread < https://github.com/notifications/unsubscribe-auth/AEvQiPvcBEQdindfwEbSAo_ hXUhicP08ks5tyg8PgaJpZM4T-pw6>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cmateu/galstreams/issues/3#issuecomment-391025188, or mute the thread https://github.com/notifications/unsubscribe-auth/AMdc-Jp8dbgk4Tf7kaT6Q1fUUbDAcX-Bks5t1CkSgaJpZM4T-pw6 .