cmateu / galstreams

Milky Way Streams Footprint Library and Toolkit for Python
BSD 3-Clause "New" or "Revised" License
46 stars 17 forks source link

Astropy coordinate frames #4

Closed adrn closed 5 years ago

adrn commented 6 years ago

Hey @cmateu 👋

Have you thought about the possibility of making Astropy coordinate frames for the streams? We support most possible astronomical coordinate transformations (including velocity components / proper motions!), like galactic, ICRS, ecliptic, etc. For stream frames, I have a few examples in gala for Pal 5, GD-1, Sagittarius, Orphan.

Let me know if you'd like to chat!

cmateu commented 6 years ago

yes, I’d absolutely like to chat about that!

I hadn’t thought about that specifically but I was definitely hoping to get some pointers to make the library more general and less home-made :)

On Jun 6, 2018, at 11:07 AM, Adrian Price-Whelan notifications@github.com wrote:

Hey @cmateu https://github.com/cmateu 👋

Have you thought about the possibility of making Astropy coordinate frames http://docs.astropy.org/en/latest/coordinates/index.html for the streams? We support most possible astronomical coordinate transformations (including velocity components / proper motions!), like galactic, ICRS, ecliptic, etc. For stream frames, I have a few examples in gala http://gala.adrian.pw/en/latest/coordinates/index.html for Pal 5, GD-1, Sagittarius, Orphan.

Let me know if you'd like to chat!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cmateu/galstreams/issues/4, or mute the thread https://github.com/notifications/unsubscribe-auth/AEvQiKuH2GTeHODizApq0th7M669OBAtks5t5_AXgaJpZM4Uc1Pz.

adrn commented 5 years ago

The first stab at this is implemented! Woohoo!