cmather / blaze-layout

A Meteor Blaze powered layout component for dynamic rendering.
Other
49 stars 8 forks source link

Should iron-router be a dependency? #20

Open zvictor opened 10 years ago

zvictor commented 10 years ago

I understand that iron-router uses blaze-layout as dependency, but why the other way around? Isn't this a mistake?

$ mrt create myProject
myProject: created.

To run your new app:
   cd myProject
   meteor

$ cd myProject/
$ mrt add blaze-layout
✓ blaze-layout
    tag: https://github.com/EventedMind/blaze-layout.git#v0.2.5

Done installing smart packages

Stand back while Meteorite does its thing

Done installing smart packages

Ok, everything's ready. Here comes Meteor!

=> Errors while scanning packages:

While building package `blaze-layout`:
error: no such package: 'iron-router'
cmather commented 10 years ago

Yes that appears to be an error.

On May 15, 2014, at 8:15 AM, zVictor notifications@github.com wrote:

I understand that iron-router uses blaze-layout as dependency, but why the other way around? Isn't this an error?

$ mrt create myProject myProject: created.

To run your new app: cd myProject meteor

$ cd myProject/ $ mrt add blaze-layout ✓ blaze-layout tag: https://github.com/EventedMind/blaze-layout.git#v0.2.5

Done installing smart packages

Stand back while Meteorite does its thing

Done installing smart packages

Ok, everything's ready. Here comes Meteor!

=> Errors while scanning packages:

While building package blaze-layout: error: no such package: 'iron-router' — Reply to this email directly or view it on GitHub.

cmather commented 10 years ago

This is all fixed up with a new layout package: https://github.com/eventedmind/iron-layout

IronRouter integration is on a feature branch: feature/iron-layout. After some app testing we'll do a patch release.