search

cmathews393 / spotify-to-plex

A python script/app to sync Spotify Playlists into Plex (optionally via Lidarr)
GNU General Public License v3.0
34 stars 3 forks source link

Improve Large Playlist Handling, Handle Missing Songs #23

Closed Kyrluckechuck closed 2 months ago

Kyrluckechuck commented 2 months ago

Description

Hello!

Not sure if you're interested in these changes being cleaned up to conform to your repositories code style, but just wanted to offer these changes up since I had to make these adjustments in order to make this script usable with some of my playlists!

This is an example output from running it ``` reading config Attempting to run for [['', ''], ['', '', '']] processing for user Processing playlists for user: User matches credentials provided, defaulting. Checking tracks in plex Checking tracks in plex Found 333 of possible 333 (Failed to find 0) Processed playlist . Checking tracks in plex No results found for artist: Calvin Harris feat. Example Found 1459 of possible 1459 (Failed to find 0) Processed playlist . Checking tracks in plex Found 57 of possible 57 (Failed to find 0) Processed playlist . No results found for artist: TEYGH Checking tracks in plex No results found for artist: Vilo No results found for artist: Alan x Walkers Found 348 of possible 348 (Failed to find 0) Processed playlist . No results found for artist: Alan x Walkers No results found for artist: Blur Violet No results found for artist: Treeworked Found 2161 of possible 2168 (Failed to find 0) Processed playlist . ```

Based on the above, you can see there is still a little bit of work that could potentially be done to clean up some additional edge cases, but this was "good enough" and much better than a couple of other Spotify-to-Plex scripts I had found from other repos which were not in as clean of a state to modify (most couldn't even get 150 songs of that 2100+ song playlist) 😅

I also added a couple of comments about what values were expected in some cases, and how it would get run by the multi-thread implementation because of the array-of-array nesting in how it was implemented 😛

cmathews393 commented 2 months ago

I'll take a look this evening probably, some of this is in my test branch already actually, but the 300 song limit is interesting, I didn't know about that.

cmathews393 commented 2 months ago

Sorry, I have been super busy with work, I will probably be able to get this tested and checked by friday and merged in.