Test with newer versions of node and update package.json engines

cmawhorter / urn-lib

Parse, validate, and format urn:, arn:, or your own custom scheme.

MIT License

4 stars 1 forks source link

Test with newer versions of node and update package.json engines #4

Closed mterrel closed 4 years ago

mterrel commented 4 years ago

This PR fixes #3. The commits in this PR:

Fix broken Travis CI builds for Node 4/5. They're broken because the version of yarn installed on Travis' default Node 4 and Node 5 versions fails while running yarn version. See yarn bug https://github.com/yarnpkg/yarn/issues/6914
Add all currently supported Node versions to CI (10, 12, 13). All pass existing tests.
Update package.json engines field to reflect new testing.

cmawhorter commented 4 years ago

i'm going to remove engines since it has only ever caused me pain and get a new version published. thanks!

mterrel commented 4 years ago

@cmawhorter Awesome! Thanks for the quick response!

cmawhorter commented 4 years ago

np. just published this and some other changes as 1.2.0. i ended up having to drop CI support for < node8 anyway because mocha... =/ but thanks for the pr!