search

cmaycumber / config-plugin-react-native-intercom

Expo plugin for adding @intercom/react-native-intercom using expo config plugins
74 stars 38 forks source link

add android icon customization functionality #32

Closed louisbyrne89 closed 1 year ago

louisbyrne89 commented 2 years ago

Intercom explains how to customize the icon in their android setup docs.

I've followed a similar implementation to how it was done by expo-notifications

I've not managed to figure out how to customize the icon color. Awaiting some clarification from intercom

fobos531 commented 1 year ago

Hey @cmaycumber, looks @expo/image-utils is missing from the package.json of the config plugin, see https://github.com/louisbyrne89/config-plugin-react-native-intercom/blob/fd05eefd1cec5d60953b5a0d7dcc925713218284/packages/intercom-react-native/src/withIntercomAndroid.ts#L16

If you try to build the config plugin right now, it fails for me with complaints of a missing @expo/image-utils. Should we add that to the dependencies list of the config plugin?

cmaycumber commented 1 year ago

Yeah I think that's a great idea! Good catch

cmaycumber commented 1 year ago

Or at least we need something in the docs that lists it as a peer dep