search

cmaycumber / config-plugin-react-native-intercom

Expo plugin for adding @intercom/react-native-intercom using expo config plugins
74 stars 38 forks source link

chore: update ios config plugin #60

Closed elmaxe closed 1 year ago

elmaxe commented 1 year ago

Fixes: #56

enagorny commented 1 year ago

This is likely needs to be a version bump, as this will make impossible to work with SDK47

WadhahEssam commented 1 year ago

the change is only one line, the rest is code styling? I think it would be better if you remove the styling @elmaxe

elmaxe commented 1 year ago

the change is only one line, the rest is code styling? I think it would be better if you remove the styling @elmaxe

Yeah it seems so. Not my commit. I can fix

elmaxe commented 1 year ago

Fixed @WadhahEssam

enagorny commented 1 year ago

I've merged the fix code and update the readme.md. But I don't have right to update it on the npm. For now you can install it using gitpkg.now.sh npm install 'https://gitpkg.now.sh/cmaycumber/config-plugin-react-native-intercom/packages/intercom-react-native?main'

@cmaycumber could you please publish it on npm? and sorry for merging it early

cmaycumber commented 1 year ago

Just got published!