search

cmaycumber / config-plugin-react-native-intercom

Expo plugin for adding @intercom/react-native-intercom using expo config plugins
74 stars 38 forks source link

fix(deps): use a valid `@expo/config-plugins` version for Expo SDK 49 #69

Closed jferrettiboke closed 5 months ago

jferrettiboke commented 11 months ago

This PR uses a valid @expo/config-plugins version to make it compatible with Expo SDK 49.

Right now, when executing npx expo-doctor@latest, developers get the following error:

Screenshot 2023-08-04 at 17 33 04

Fixes #62

LeoAnt02 commented 10 months ago

Any reason why this is not merged ?

enagorny commented 10 months ago

I have the rights to merge, but in order to create an npm release we need @cmaycumber help

cmaycumber commented 10 months ago

I'll see if I can get this in!

@enagorny I talked about this a little while ago. Would it make sense for some sort of CI? I imagined that intercom would pick this up by now and it'd be officially integrated into the @expo/config-plugins repo. We may want to port this over and archive this so that you have more maintainability.

enagorny commented 10 months ago

I don't work for intercom and don't know if intercom company is doing anything for having expo config plugin.

GabrielDierks commented 7 months ago

@cmaycumber Is there any update on expo picking this up as an official config-plugin? It would be quite important to have this maintained actively, since it is already not working anymore with the latest react-native-intercom versions (6.0.0+) which have some breaking updates to be compatible with iOS 17.

mfpardini commented 5 months ago

Any reason why this is not merged yet?

edgarciametro commented 5 months ago

Can this be merged?

mfpardini commented 5 months ago

Can this be merged?

I think so I've tested with SDK 49 and it works IOS 16.7 Android 12

cmaycumber commented 5 months ago

Will publish later today!

jmorrice commented 4 months ago

Was this ever published to npm?