search

cmb69 / calendar_xh

Event calendars for CMSimple_XH
GNU General Public License v3.0
1 stars 1 forks source link

ics import fails #47

Closed frase-git closed 3 years ago

frase-git commented 3 years ago

First: Many thanks for version 2.0

Unfortunately, attempts to import complex ics files failed with the following message (white page):

Uncaught TypeError: Argument 1 passed to Calendar\Event::create() must be of the type string, null given, called in \plugins\calendar\classes\ICalendarReader.php on line 95 and defined in \plugins\calendar\classes\Event.php:72 Stack trace:

0 \plugins\calendar\classes\ICalendarReader.php(95): Calendar\Event::create(NULL, NULL, NULL, NULL, 'Neujahr in Deut...', '', '', NULL)

1 \plugins\calendar\classes\ICalendarReader.php(58): Calendar\ICalendarReader->parse()

2 \plugins\calendar\classes\IcalImportController.php(82): Calendar\ICalendarReader->read()

3 \plugins\calendar\classes\Plugin.php(129): Calendar\IcalImportController->importAction()

4 \plugins\calendar\classes\Event.php on line 72

With simpler files, however, the import works without problems.

(Example of a complex failed file: https://www.ferienwiki.de/exports/de -> "Feiertage gesamt"

cmb69 commented 3 years ago

Many thanks for version 2.0

Actually, I'm happy to have it released after such a long time, and I think it's better (at least internally) than I had hoped – still, far from good.

Many thanks for checking it and filing bug reports! :)

Unfortunately, attempts to import complex ics files failed with the following message (white page):

Confirmed. This is actually a duplicate of #19. For a quick workaround see https://cmsimpleforum.com/viewtopic.php?f=16&t=13290#p64837. I'll try to address this soonish, since being able to import these files makes a whole lot of sense. And at the very least, the import shouldn't produce a WSOD.

cmb69 commented 3 years ago

Re-opening, to distinguish this bug from the enhancement of #19.