search

cmbruns / gz3doom

Classic Doom/Heretic/Hexen games in stereo 3D and VR; modified version of gzdoom.
http://rotatingpenguin.com/gz3doom/
88 stars 16 forks source link

Several entries for different versions are shown in Programs and Features when updating without uninstallation. #173

Open wadim-al opened 7 years ago

wadim-al commented 7 years ago

Steps:

  1. Install 0.5.2 version
  2. Start installer for 0.5.3 version
  3. Select the same folder to install
  4. Finish installation
  5. Open Control panel > Programs and Features

Expected: Only one uninstaller entry is listed in Control panel > Programs and Features for the latest version installed.

Actual: In my case there are 4 GZDoom vivedoom uninstallers listed for each version I tried.

Environment: Win10x64

Screenshot: untitled

cmbruns commented 7 years ago

If I understand correctly, the user here is manually installing into the same destination folder, not the default, without first uninstalling the previous version.

This seems like a minor problem.

One approach would be to set the CPACK variable CPACK_NSIS_ENABLE_UNINSTALL_BEFORE_INSTALL in CMakeLists.txt https://cmake.org/cmake/help/v3.0/module/CPackNSIS.html

This way, the user might be asked during install if they want to uninstall the previous version. Of course, this won't solve the problem where the use might say "no", don't uninstall the previous version, and then make the same complaint we are hearing here.