cmbruns / pyopenvr

Unofficial python bindings for Valve's OpenVR virtual reality SDK
BSD 3-Clause "New" or "Revised" License
245 stars 39 forks source link

Add install and extra requires #58

Closed godber closed 5 years ago

godber commented 5 years ago

I have added install_requires which will provide dependencies for all installs and extras_require which should support installations that install extra dependencies.

So

I should probably add this info to the README ... also PySide seems dead, I can add it but not conditionally for older pythons (as far as I understand, maybe it is possible). I don't have VR on linux handy to test SDL2, I would have added it if it appeared to be pip installable, but it didn't. I haven't had a chance to verify, though I could.

Note I also add a couple classifiers.

refs #31

godber commented 5 years ago

I should really probably add to the README before you accept this, but I wanted to get something up sooner rather than later.

cmbruns commented 5 years ago

@godber Thank you for this.

Numpy and PyOpenGL are not strictly required to make use of the openvr wrapper. I suppose they are a bit more required than glfw and all, for the samples. I should probably eventually separate the opengl samples from the core openvr wrapper into a separate module or modules.

godber commented 5 years ago

You're welcome.

Ah yeah, it didn't occur to me that those weren't actually required ... just for the examples. I could add a openvr[all] that does everything or move the numpy and PyOpenGL to be installed with each windowing toolkit. Let me know if you'd like something else.