cmbruns / pyopenvr

Unofficial python bindings for Valve's OpenVR virtual reality SDK
BSD 3-Clause "New" or "Revised" License
245 stars 39 forks source link

Incorporate changes recommended by risa2000 #66

Closed cmbruns closed 4 years ago

cmbruns commented 5 years ago

@risa2000 Could you please review this pull request? I incorporated the ideas from your pull requests, but I modified the translator so the changes would apply more generally.

Sorry I made a lot of whitespace changes, because I wanted all line endings to be newlines. It's probably much easier for you to review if you ignore whitespace changes by adding ?w=1 to the URL, like https://github.com/cmbruns/pyopenvr/pull/66/files?w=1

Under the "Files changed" tab above, you can add comments to specific lines of code, and you can make general comments and/or give general approval by clicking the green "Review changes" button at the upper right corner of the "Files changed" view.

I really appreciate your thoughful insights about this project.