search

cmbruns / pyopenxr

Unofficial python bindings for OpenXR access to VR and AR devices
Apache License 2.0
103 stars 8 forks source link

Allow current PyOpenGL version 3.1.7 #106

Open tomgoddard opened 5 months ago

tomgoddard commented 5 months ago

Currently the pyopenxr setup.cfg file pins the PyOpenGL version to 3.1.6 while the current PyOpenGL version is 3.1.7

    ; PyOpenGL 3.1.7 causes CI failure on github/ubuntu
    PyOpenGL==3.1.6

The only clue I could find why this was done is in the comment in that file that says "CI failure on github/ubuntu". It would be very helpful if pyopenxr were compatible with current PyOpenGL. I am using pyopenxr in a molecular visualization package ChimeraX used by about 10000 researchers and cannot roll back PyOpenGL for this large application for pyopenxr. Currently I install pyopenxr 1.0.3301 without dependencies and use pyopengl 3.1.7 without problems on Windows. ChimeraX does not support VR on Ubuntu currently so I have not tried that.

cmbruns commented 5 months ago

Thanks for reporting this.

That's a hack I put in to make the linux headless continuous integration builds succeed. On ubuntu in headless mode, from OpenGL import GL fails with an error when using PyOpenGL 3.1.7, but not with 3.1.6.

It seems I can put this hack into the workflow files instead of into config.cfg. That would be a better fix. I'll try to update the release soon.

I'm aware of Chimera and of you. I was a practicing structural biochemist for one decade. It's an honor to help you in any way I can.

tomgoddard commented 5 months ago

Thanks! I've worked around the issue so it is not urgent. I've added OpenXR support to ChimeraX in addition to OpenVR (using your pyopenvr for many years now) so VR users can connect to Quest headsets without needing SteamVR. But it may be that there recently released SteamLink that connects to Quest without needing the Oculus app is a better option since people report SteamLink being more stable than Quest AirLink. At any rate, your pyopenvr and pyopenxr work made all these attempts at VR for biology researchers looking at proteins, nucleic acids and drugs possible. Thank you for that!