cmccormack / minesweeper

Simple Minesweeper Game in JS
MIT License
1 stars 3 forks source link

Added build step to dev server #16

Closed cmccormack closed 5 years ago

cmccormack commented 5 years ago

Possibly temporary, possibly permanent fix to empty index being loaded if build not run first.

bradtaniguchi commented 5 years ago

Shouldn't webpack just be updated to move the assets aswell as the index.html folder?

cmccormack commented 5 years ago

Shouldn't webpack just be updated to move the assets aswell as the index.html folder?

I'm not certain why webpack isn't serving the compiled JS from some temp directory, not sure what the solution is just yet but this at least builds the TS to JS so webpack-dev-server has somewhere to serve the app when in development.

bradtaniguchi commented 5 years ago

I'm not certain why webpack isn't serving the compiled JS from some temp directory, not sure what the solution is just yet but this at least builds the TS to JS so webpack-dev-server has somewhere to serve the app when in development.

I'll check this out on my end to see whats going on :)

bradtaniguchi commented 5 years ago

I checked it out on my end.

I see, the start:dev runs the webpack dev-server, which doesn't do anything with the index.html as expected, and serves probably from memory (which is kinda annoying).

I tried a few things to "fix" it, but yea the given fix should work for now :)

cmccormack commented 5 years ago

@bradtaniguchi resolved conflicts if you think it's ready to merge

bradtaniguchi commented 5 years ago

Whoa netlify hooks, fancy!