search

cmcdonaldca / shopify.net

Lightweight object-oriented .NET client for the Shopify API
MIT License
62 stars 32 forks source link

Throws exception for post request when do not return is returned in response. #4

Open ArjunVachhani opened 9 years ago

ArjunVachhani commented 9 years ago

There are some web services in which data can be posted but web service do not return any thing in response, in such case ApiClient.Post(url, obj); throws exception Error reading JObject from JsonReader. Path '', line 0, position 0.

for example in https://docs.shopify.com/api/recurringapplicationcharge#activate has to post data to web-service but web service do not return any data in response.

colinfoko commented 9 years ago

feel free to send over a pull request that fixes it and I'll approve it.

ArjunVachhani commented 9 years ago

@colinfoko Barranger Ridler already solved and commited. https://github.com/cmcdonaldca/shopify.net/commit/d0088982c470de603db1ed6a144215f134deb24b

colinfoko commented 9 years ago

Oh ok, so should we close this issue then?

ArjunVachhani commented 9 years ago

Nuget package ID: ShopifyAPI, version: 1.0.0 still has this issue

cmcdonaldca commented 9 years ago

ok, now I understand. I'm not sure if I can update. It's been a few years since I've been in windows. Will look into it.

On Wed, Nov 4, 2015 at 2:50 AM ArjunVachhani notifications@github.com wrote:

Nuget package still has this issue

— Reply to this email directly or view it on GitHub https://github.com/cmcdonaldca/shopify.net/issues/4#issuecomment-153623617 .