cmcginty / PyWeather

Bindings for Davis Vantage Pro and Pro2 weather stations, upload of weather data (e.g. wunderground.com, pwsweather.com), and meteorological calculation/conversion functions.
GNU General Public License v3.0
60 stars 34 forks source link

method `davis.VatagePro._dmpaft_cmd()` is returning always None #13

Closed saveriogzz closed 2 years ago

saveriogzz commented 2 years ago

The following lines are trying compare bytes (ack) with a string self.ACK

https://github.com/cmcginty/PyWeather/blob/78fc2d5b24ef31058e722475830684a1c3eaafbb/weather/stations/davis.py#L473-L476

saveriogzz commented 2 years ago

Commit https://github.com/saveriogzz/PyWeather/commit/305f8f40cfd3ca78a281df2c255b1fc2385e8e0e should solve this issue