fixing issues in VantagePro class - Githubissues

cmcginty / PyWeather

Bindings for Davis Vantage Pro and Pro2 weather stations, upload of weather data (e.g. wunderground.com, pwsweather.com), and meteorological calculation/conversion functions.

GNU General Public License v3.0

60 stars 34 forks source link

fixing issues in VantagePro class #14

Closed saveriogzz closed 2 years ago

saveriogzz commented 2 years ago

This PR is my attempt at solving various issues that I have encountered when using the VantagePro API in weather/stations/davis.py.

A non comprehensive list of issues encountered:

12 : The exception was raised anytime there was an attempt to connect to the station.
13 : This method was always returning None because https://github.com/cmcginty/PyWeather/issues/13#L475 was comparing bytes with strings!
Similarly, #11 was producing errors because trying to encode bytes.

@cmcginty I'm happy to discuss further :) let me know what you think