search

cmckni3 / ruby-jasperserver

Rails integration for JasperSoft Reports
MIT License
19 stars 15 forks source link

be a little forgiving on the rails dependency #10

Closed nicwillemse closed 8 years ago

nicwillemse commented 8 years ago

9 Allowed rails 5 compatibility

nicwillemse commented 8 years ago

@cmckni3 could you look into this for me please ? Im unable to recreate this ?

cmckni3 commented 8 years ago

@nicwillemse What is this PR trying to accomplish?

The tests on master should be good again. webmock 2.0 was released recently so I specified 1.24.x in the Gemfile.

nicwillemse commented 8 years ago

@cmckni3 i have simply updated the rails dependency ?

cmckni3 commented 8 years ago

This change shouldn't have made a difference. I created a rails app with Rails 5 RC1 and can use the gem from within the app fine.

@nicwillemse Are you using any other gems with a strict Rails dependency?

I see you created some issues for pdfjs_viewer-rails (locked to Rails 4.2.x) and grape_on_rails_routes (locked to Rails >= 3.1.1 < 5). These gems will produce a bundler "unable to resolve dependencies" message. These gems will be included in the message as unresolvable and potentially other gems depending on Rails (depends on bundler version).

cmckni3 commented 8 years ago

Ideally, I think I could get away with just depending on railties. I don't think I'm using anything from Rails itself but I would have to double check.

nicwillemse commented 8 years ago

Thanks for you help @cmckni3 im happy to make the change ?

cmckni3 commented 8 years ago

Works for me. I added you as a collaborator.

Do you have other changes to make for this PR?

nicwillemse commented 8 years ago

@cmckni3 thanks for the add.

Im done with this PR, I tried switching it to railties but it seems there is a dependency on rails.

Perhaps we can remove this as a different PR and close this ?

oMethodError: undefined methodactive_record' for #Rails::Application::Configuration:0x007f905ae20350 /Users/nic/Projects/rails-jasperserver/test/dummy/config/application.rb:50:in <class:Application>' /Users/nic/Projects/rails-jasperserver/test/dummy/config/application.rb:9:inmodule:Dummy' /Users/nic/Projects/rails-jasperserver/test/dummy/config/application.rb:8:in <top (required)>' /Users/nic/Projects/rails-jasperserver/test/dummy/Rakefile:5:inrequire' /Users/nic/Projects/rails-jasperserver/test/dummy/Rakefile:5:in <top (required)>' /Users/nic/Projects/rails-jasperserver/Rakefile:24:inload' /Users/nic/Projects/rails-jasperserver/Rakefile:24:in <top (required)>'

cmckni3 commented 8 years ago

That makes sense because the the dummy application uses the Rails tasks. That can be fixed in a new PR.